Deletion of lock file should not fail if lock not found #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously we would report an error if we could not delete the lock file. However, the lock file may not exist if we never had to download anything! So the attempt to delete the lock file would fail, bubbling up as if it were an error, but it should not be one. As such, we now always ignore if the deletion fails.
A potential side effect is if we created the lock file and then the drive becomes unavailable or read only, and we cannot delete it but we should have. Then, this will cause an issue on the next load attempt, and the user is informed to delete the lock file manually.
Architectural Changes
No change
New Features
No change
Improvements
No change
Bug Fixes
No change
Testing and validation
No change.
Documentation
This PR does not primarily deal with documentation changes.