Allow for add_{sma/inc/etc} to bubble up failures #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If
add_sma_km
was called on a hyperbolic orbit, then the error was not caught and the library would panic. This applied to all orbital elements. This PR fixes this, allowing for the error to rise up.Architectural Changes
No change
New Features
No change
Improvements
No change
Bug Fixes
No change
Testing and validation
No change!
Documentation
This PR does not primarily deal with documentation changes.