Fix transformation when it involved multi-barycenter hops #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… downloaded However, if the data cannot be downloaded or the data folder be written to, then an error is still raised. We don't want to hide these errors to the user, only allow rustdocs to build
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a bug when the transformation involved multiple barycenter hops. Specifically, one of the barycenter translations was skipped. It is no longer skipped.
Fixes #285 (poorly named branch -- oops).
Architectural Changes
No change
New Features
No change
Improvements
No change
Bug Fixes
There was a bug when the transformation involved multiple barycenter hops.
Testing and validation
Add the LRO test case where the state of LRO wrt the Sun is computed in SPICE and ANISE. Ensure that the position error is exactly zero (and velocity error is less than 1 mm/s).
Documentation
This PR does not primarily deal with documentation changes.