Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Python enhancements #161

Merged
merged 6 commits into from
Jun 2, 2023
Merged

Conversation

ChristopherRabotin
Copy link
Member

@ChristopherRabotin ChristopherRabotin commented Jun 2, 2023

Effects

  • Rename DynamicTrajectory to TrajectoryLoader, since that's all it does
  • Allow pickling of TrajectoryLoader
  • Fix OEM parsing if multiple META sections
  • Create StateParameter from its name (available in Rust but not in Python)

If this change adds or modifies a validation case

  • No.

- Rename DynamicTrajectory to TrajectoryLoader, since that's all it does
- Allow pickling of TrajectoryLoader
- Fix OEM parsing if multiple META sections

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 86.66% and project coverage change: -0.07 ⚠️

Comparison is base (c9e51e4) 66.45% compared to head (13ef15c) 66.38%.

❗ Current head 13ef15c differs from pull request most recent head ccee18f. Consider uploading reports for the commit ccee18f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   66.45%   66.38%   -0.07%     
==========================================
  Files         127      127              
  Lines       32378    32391      +13     
==========================================
- Hits        21516    21502      -14     
- Misses      10862    10889      +27     
Impacted Files Coverage Δ
src/io/trajectory_data.rs 0.00% <0.00%> (ø)
src/md/param.rs 58.97% <ø> (ø)
tests/propagation/trajectory.rs 0.00% <0.00%> (ø)
src/io/watermark.rs 96.55% <100.00%> (-0.51%) ⬇️
src/md/trajectory/orbit_traj.rs 92.15% <100.00%> (+0.11%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
+ TrajectoryLoader can convert to concrete trajectory in Python too `to_orbit_traj` and `to_spacecraft_traj`
+ OrbitTraj now available in Python
+ Rename Traj in Python to SpacecraftTraj
+ Can downcast between both in Python as well

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
@ChristopherRabotin ChristopherRabotin merged commit 438cfb7 into master Jun 2, 2023
18 of 19 checks passed
@ChristopherRabotin ChristopherRabotin deleted the python-usability-enhancements branch June 2, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant