Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc/test) improve r1/r2/r3 rotation matrix #176

Merged
merged 1 commit into from
Jun 10, 2023
Merged

(doc/test) improve r1/r2/r3 rotation matrix #176

merged 1 commit into from
Jun 10, 2023

Conversation

ThibFrgsGmz
Copy link
Contributor

  • Improved docstrings: more detail and better rendering in the IDE (VSCode at least)
  • Added some unit tests

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: +0.10 🎉

Comparison is base (2ee5225) 66.33% compared to head (9f254a5) 66.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   66.33%   66.44%   +0.10%     
==========================================
  Files         127      127              
  Lines       32445    32466      +21     
==========================================
+ Hits        21524    21571      +47     
+ Misses      10921    10895      -26     
Impacted Files Coverage Δ
src/utils.rs 56.98% <72.72%> (+5.59%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristopherRabotin ChristopherRabotin merged commit 3a029f4 into nyx-space:master Jun 10, 2023
@ThibFrgsGmz ThibFrgsGmz deleted the feat/improve_rot_matrix branch June 10, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants