-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite http webhook api #478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l7ssha
reviewed
Apr 30, 2023
l7ssha
reviewed
May 4, 2023
l7ssha
approved these changes
May 4, 2023
Rapougnac
pushed a commit
that referenced
this pull request
May 22, 2023
* Create models for channels * Add channel manager * Export channel models & manager * Add tests for ChannelManager * Fix bugs found by tests * Add maybeParseMany parsing helper * Add flags to threads * Add channel update method * Allow flags to be combined * Allow single flags to be used as a set of flags * Add channel tests * Fix issues found by tests * Add channel delete method * Add message object classes * Add channels manager to client * Implement message parsing * Implement channel endpoints * Simplify channel model structure * Move sentinels to their own files * Use specific builder types * Add message manager to channels * Add helper shortcuts * Correct test folder name * Give each fetch test a unique name * Add channel endpoint tests * Add additional ChannelManager parsing tests * Add message manager test * Add missing message endpoint tests * Fix issues found by tests * Remove embed.type field * Add builder tests for channels * Add extra tests & fix bugs found by tests * Update test * Remove async test * Only load channel id if environment variable is provided * Move channel methods to concrete subclasses * Normalize cache accesses between resources of the same type * Prefer getters over late final * Remove FlagsCombinable as it is no longer needed * Start adding documentation to channel classes * Docuument channel and message managers * Move test samples to global scope * Implement the webhook http api * Rewrite integration test & add webhook integration test * Fix issues found by webhook tests * Document webhooks
abitofevrything
added a commit
that referenced
this pull request
Jun 19, 2023
* Models for invites * Add ToStringHelper to Invite Co-authored-by: Abitofevrything <54505189+abitofevrything@users.noreply.github.com> * Rewrite http channels API (#469) * Create models for channels * Add channel manager * Export channel models & manager * Add tests for ChannelManager * Fix bugs found by tests * Add maybeParseMany parsing helper * Add flags to threads * Add channel update method * Allow flags to be combined * Allow single flags to be used as a set of flags * Add channel tests * Fix issues found by tests * Add channel delete method * Add message object classes * Add channels manager to client * Implement message parsing * Implement channel endpoints * Simplify channel model structure * Move sentinels to their own files * Use specific builder types * Add message manager to channels * Add helper shortcuts * Correct test folder name * Give each fetch test a unique name * Add channel endpoint tests * Add additional ChannelManager parsing tests * Add message manager test * Add missing message endpoint tests * Fix issues found by tests * Remove embed.type field * Add builder tests for channels * Add extra tests & fix bugs found by tests * Update test * Remove async test * Only load channel id if environment variable is provided * Move channel methods to concrete subclasses * Normalize cache accesses between resources of the same type * Prefer getters over late final * Remove FlagsCombinable as it is no longer needed * Start adding documentation to channel classes * Docuument channel and message managers * Rewrite http webhook api (#478) * Create models for channels * Add channel manager * Export channel models & manager * Add tests for ChannelManager * Fix bugs found by tests * Add maybeParseMany parsing helper * Add flags to threads * Add channel update method * Allow flags to be combined * Allow single flags to be used as a set of flags * Add channel tests * Fix issues found by tests * Add channel delete method * Add message object classes * Add channels manager to client * Implement message parsing * Implement channel endpoints * Simplify channel model structure * Move sentinels to their own files * Use specific builder types * Add message manager to channels * Add helper shortcuts * Correct test folder name * Give each fetch test a unique name * Add channel endpoint tests * Add additional ChannelManager parsing tests * Add message manager test * Add missing message endpoint tests * Fix issues found by tests * Remove embed.type field * Add builder tests for channels * Add extra tests & fix bugs found by tests * Update test * Remove async test * Only load channel id if environment variable is provided * Move channel methods to concrete subclasses * Normalize cache accesses between resources of the same type * Prefer getters over late final * Remove FlagsCombinable as it is no longer needed * Start adding documentation to channel classes * Docuument channel and message managers * Move test samples to global scope * Implement the webhook http api * Rewrite integration test & add webhook integration test * Fix issues found by webhook tests * Document webhooks * Rewrite http application api (#477) * Create models for channels * Add channel manager * Export channel models & manager * Add tests for ChannelManager * Fix bugs found by tests * Add maybeParseMany parsing helper * Add flags to threads * Add channel update method * Allow flags to be combined * Allow single flags to be used as a set of flags * Add channel tests * Fix issues found by tests * Add channel delete method * Add message object classes * Add channels manager to client * Implement message parsing * Implement channel endpoints * Simplify channel model structure * Move sentinels to their own files * Use specific builder types * Add message manager to channels * Add helper shortcuts * Correct test folder name * Give each fetch test a unique name * Add channel endpoint tests * Add additional ChannelManager parsing tests * Add message manager test * Add missing message endpoint tests * Fix issues found by tests * Remove embed.type field * Add builder tests for channels * Add extra tests & fix bugs found by tests * Update test * Remove async test * Only load channel id if environment variable is provided * Move channel methods to concrete subclasses * Normalize cache accesses between resources of the same type * Prefer getters over late final * Remove FlagsCombinable as it is no longer needed * Start adding documentation to channel classes * Docuument channel and message managers * Implement the HTTP Application API * Add application manager to client * Rewrite http voice api (#479) * Create models for channels * Add channel manager * Export channel models & manager * Add tests for ChannelManager * Fix bugs found by tests * Add maybeParseMany parsing helper * Add flags to threads * Add channel update method * Allow flags to be combined * Allow single flags to be used as a set of flags * Add channel tests * Fix issues found by tests * Add channel delete method * Add message object classes * Add channels manager to client * Implement message parsing * Implement channel endpoints * Simplify channel model structure * Move sentinels to their own files * Use specific builder types * Add message manager to channels * Add helper shortcuts * Correct test folder name * Give each fetch test a unique name * Add channel endpoint tests * Add additional ChannelManager parsing tests * Add message manager test * Add missing message endpoint tests * Fix issues found by tests * Remove embed.type field * Add builder tests for channels * Add extra tests & fix bugs found by tests * Update test * Remove async test * Only load channel id if environment variable is provided * Move channel methods to concrete subclasses * Normalize cache accesses between resources of the same type * Prefer getters over late final * Remove FlagsCombinable as it is no longer needed * Start adding documentation to channel classes * Docuument channel and message managers * Move test samples to global scope * Implement the webhook http api * Rewrite integration test & add webhook integration test * Fix issues found by webhook tests * Document webhooks * Implement the HTTP Application API * Add application manager to client * Implement the voice http api * Add voice tests * Add documentation * Expose members, add manager and fix various issues * Fix channel prop and add endpoints, add manager to mixin * Format * Testing * Finish implementing invites --------- Co-authored-by: Abitofevrything <54505189+abitofevrything@users.noreply.github.com> Co-authored-by: Abitofevrything <mylo.fawcett@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the HTTP Webhook resource API
Prerequisite: #469
Connected issues & other potential problems
Closes #466
Type of change
Checklist:
dart analyze
ormake analyze
and fixed all issuesdart format --set-exit-if-changed -l 160 ./lib
ormake format
and fixed all issues