Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Commit

Permalink
#437: don't rely on sizes of externally generated files
Browse files Browse the repository at this point in the history
Tests that try to match exact file sizes are prone to break for unexpected versions of p7zip and par2cmdline.
  • Loading branch information
sinic authored and hugbug committed Aug 31, 2017
1 parent 6975f24 commit 6ce0cec
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
8 changes: 5 additions & 3 deletions tests/functional/rename/rename_opt2_test.py
@@ -1,3 +1,5 @@
import re

nzbget_options = ['ParRename=no', 'RarRename=no', 'ParCheck=auto', 'DirectRename=yes']

def test_rename_obf1(nserv, nzbget):
Expand Down Expand Up @@ -35,13 +37,13 @@ def test_rename_obf1dmf(nserv, nzbget):
def test_rename_obf1dmf2(nserv, nzbget):
nzb_content = nzbget.load_nzb('obfuscated1.nzb')
nzb_content = nzb_content.replace('abc.01?1=0:100000', 'abc.01?1=0:100000!0')
nzb_content = nzb_content.replace('abc.00?1=0:108', 'abc.00?1=0:108!0')
nzb_content = re.sub(r'abc.00\?1=0:\d+', r'\g<0>!0', nzb_content)
hist = nzbget.download_nzb('obfuscated1-damaged-first2.nzb', nzb_content, unpack=True)
assert hist['Status'] == 'SUCCESS/UNPACK'

def test_rename_obf1dmp(nserv, nzbget):
nzb_content = nzbget.load_nzb('obfuscated1.nzb')
nzb_content = nzb_content.replace('parrename.vol0+1.par2?1=0:57736', 'parrename.vol0+1.par2?1=0:57736!0')
nzb_content = re.sub(r'parrename.vol0+1.par2\?1=0:\d+', r'\g<0>!0', nzb_content)
hist = nzbget.download_nzb('obfuscated1-damaged-par.nzb', nzb_content, unpack=True)
assert hist['Status'] == 'SUCCESS/UNPACK'

Expand All @@ -60,7 +62,7 @@ def test_rename_obf3dmf(nserv, nzbget):
def test_rename_obf3dmf2(nserv, nzbget):
nzb_content = nzbget.load_nzb('obfuscated3.nzb')
nzb_content = nzb_content.replace('abc.01?11=0:100000', 'abc.01?11=0:100000!0')
nzb_content = nzb_content.replace('abc.00?1=0:4704', 'abc.00?1=0:4704!0')
nzb_content = re.sub(r'abc.00\?1=0:\d+', r'\g<0>!0', nzb_content)
hist = nzbget.download_nzb('obfuscated3-damaged-first2.nzb', nzb_content, unpack=True)
assert hist['Status'] == 'WARNING/HEALTH'

Expand Down
8 changes: 5 additions & 3 deletions tests/functional/rename/rename_opt3_test.py
@@ -1,3 +1,5 @@
import re

nzbget_options = ['ParRename=yes', 'RarRename=yes', 'ParCheck=auto', 'DirectRename=yes']

def test_rename_obf1(nserv, nzbget):
Expand Down Expand Up @@ -35,13 +37,13 @@ def test_rename_obf1dmf(nserv, nzbget):
def test_rename_obf1dmf2(nserv, nzbget):
nzb_content = nzbget.load_nzb('obfuscated1.nzb')
nzb_content = nzb_content.replace('abc.01?1=0:100000', 'abc.01?1=0:100000!0')
nzb_content = nzb_content.replace('abc.00?1=0:108', 'abc.00?1=0:108!0')
nzb_content = re.sub(r'abc.00\?1=0:\d+', r'\g<0>!0', nzb_content)
hist = nzbget.download_nzb('obfuscated1-damaged-first2.nzb', nzb_content, unpack=True)
assert hist['Status'] == 'SUCCESS/UNPACK'

def test_rename_obf1dmp(nserv, nzbget):
nzb_content = nzbget.load_nzb('obfuscated1.nzb')
nzb_content = nzb_content.replace('parrename.vol0+1.par2?1=0:57736', 'parrename.vol0+1.par2?1=0:57736!0')
nzb_content = re.sub(r'parrename.vol0+1.par2?1=0:\d+', r'\g<0>!0', nzb_content)
hist = nzbget.download_nzb('obfuscated1-damaged-par.nzb', nzb_content, unpack=True)
assert hist['Status'] == 'SUCCESS/UNPACK'

Expand All @@ -60,7 +62,7 @@ def test_rename_obf3dmf(nserv, nzbget):
def test_rename_obf3dmf2(nserv, nzbget):
nzb_content = nzbget.load_nzb('obfuscated3.nzb')
nzb_content = nzb_content.replace('abc.01?11=0:100000', 'abc.01?11=0:100000!0')
nzb_content = nzb_content.replace('abc.00?1=0:4704', 'abc.00?1=0:4704!0')
nzb_content = re.sub(r'abc.00\?1=0:\d+', r'\g<0>!0', nzb_content)
hist = nzbget.download_nzb('obfuscated3-damaged-first2.nzb', nzb_content, unpack=True)
assert hist['Status'] == 'SUCCESS/UNPACK'

Expand Down

0 comments on commit 6ce0cec

Please sign in to comment.