Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Rar-rename may conflict with dupe par-repair #442

Open
1 of 2 tasks
hugbug opened this issue Sep 11, 2017 · 0 comments
Open
1 of 2 tasks

Rar-rename may conflict with dupe par-repair #442

hugbug opened this issue Sep 11, 2017 · 0 comments
Milestone

Comments

@hugbug
Copy link
Member

hugbug commented Sep 11, 2017

When both dupe par-repair (option ParCheck=dupe) and rar-rename (option RarRename=yes) are active the following may happen:

  • par-check finds a suitable dupe par source and scans files from it;
  • if the new par source contains completely undamaged files the par-repair decides to use the whole files instead of blocks of these files;
  • the undamaged files are moved from dupe source directory into current (repair) directory and the existing (damaged) files are renamed by adding ".1" extension (as par-repair usually does);
  • after the par-repair succeeds the cleanup routine doesn't correctly detect leftover-files and keeps the ".1" files undeleted;
  • after repair the rar-renamer kicks in and may use leftover-files (".rar.1") instead of repaired files (".rar") depending on which files are read first when scanning directory;
  • rar-renamer decides that renaming is necessary and renames all archive files using damaged files (".rar.1") which it has found on previous step;
  • unpack fails.

In this issue two improvements can be made:

  • rar-renamer should find all suitable rar-volumes and choose the right one (the one which happens to have correct file name);
  • par-repairer should better detect and delete leftovers when dupe sources were used.
@hugbug hugbug added this to the v20 milestone Sep 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant