Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker support #55

Merged
merged 26 commits into from
Nov 15, 2023
Merged

Docker support #55

merged 26 commits into from
Nov 15, 2023

Conversation

phnzb
Copy link
Collaborator

@phnzb phnzb commented Nov 10, 2023

  • added docker support for NZBGet
  • added workflow for build and push to DockerHub and GitHub

Copy link
Member

@luckedea luckedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good

@luckedea luckedea added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 15, 2023
@luckedea luckedea linked an issue Nov 15, 2023 that may be closed by this pull request
Copy link
Member

@luckedea luckedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome update, let's merge.

@phnzb phnzb merged commit 1913e33 into develop Nov 15, 2023
@phnzb phnzb deleted the feature/docker branch November 15, 2023 14:20
dnzbk added a commit that referenced this pull request Feb 9, 2024
nzbget-23.0
  - Features:
    - Extension Manager [#76](7348b19);
        * The new nzbget extension system, which makes it easy to download/update/delete 
        extensions with backward compatibility with the old system;
        * extensions [master list](https://github.com/nzbgetcom/nzbget-extensions/);
        * changed:
          -  RPC request "configtemplates" -  no longer returns script templates, but only the config template;
        * added:
          - new RPC requests:
            - "loadextensions" - loads all extensions from {ScriptDIR} and returns an array of structures in JSON/XML formats;
            - "updateextension" - downloads by url and name and installs the extension. Returns 'true' or error response in JSON/XML formats;
            - "deleteextension" - deletes extension by name. Returns 'true' or error response in JSON/XML formats;
            - "downloadextension" - downloads by url and installs the extension. Returns 'true' or error response in JSON/XML formats;
            - "testextension" - tries to find the right executor program for the extension, e.g. Python. 
            Returns 'true' or error response in JSON/XML formats;
          - "EXTENSION MANAGER" section in webui to download/delete/update extensions;
          - Boost.Json library to work with JSON;
          - more unit tests;
        * refactored:
          - replaced raw pointers with smart pointers and const refs where possible for memory safty reasons;
        * removed:
          - testdata_FILES from Makefile.am;
          - EMail and Logger scripts;
    - Docker support [#55](1913e33);
    - Synology support (spk) [#72](3f8fd6d);
    - QNAP support [#158](9676c77);
    - aarch64 mipseb mipsel ppc6xx ppc500 architectures to linux build [#61](9599854) [#146](fcc104d);
    - article read chunk size [#52](1aa42f2);
      * Added ArticleReadChunkSize config option which allows to adjust 
      the buffer size for customization on different platforms, which can lead to increased performance;
    - increased the number of default connections to 8  [#54](55eca4c);
    - automatic search for a suitable interpreter on POSIX [#74](ec0756d);
    - certificate verification levels [#150](5956a17);
        * levels:
          - None: NO certificate signing check, NO certificate hostname check; 
          - Minimal: certificate signing check, NO certificate hostname check;
          - Strict: certificate signing check, certificate hostname check;
        * tested on a mock nzbget NNTP nserv server with self-signed certificate and got expected results:
          - "Strict" -> test failed;
          - "Minimal" -> test failed;
          - "None" -> test passed";
  - Bug fixies:
    - possible memory corruption [#148](16ab25d);
  - For developers:
    - fixed unit tests (Windows only for now) and started migration to CMake [#64](73e8c00);
      * We are going to completely migrate to CMake as a more universal one for cross-platform development and drop autotools and MSBuild;
    - using libxml2 on Windows and vcpkg package manager to install dependencies [#70](f8cb2bd);
      * libxml2 library is now used on Windows to work with xml in the same way we already do on Linux and macOS;
      * removed platform-dependent code for working with xml on Windows;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a docker container?
2 participants