docs: add bitwise operation gadgets to o1js #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
garwalsh
reviewed
Nov 20, 2023
garwalsh
reviewed
Nov 20, 2023
garwalsh
reviewed
Nov 20, 2023
garwalsh
reviewed
Nov 20, 2023
garwalsh
reviewed
Nov 20, 2023
garwalsh
reviewed
Nov 20, 2023
nicc
reviewed
Nov 21, 2023
nicc
reviewed
Nov 21, 2023
nicc
reviewed
Nov 21, 2023
nicc
reviewed
Nov 21, 2023
…Would suggest eng. review as this involved some interpretation
…explicitly in subsequent paragraphs
barriebyron
commented
Dec 8, 2023
barriebyron
commented
Dec 8, 2023
barriebyron
commented
Dec 8, 2023
barriebyron
commented
Dec 8, 2023
barriebyron
commented
Dec 8, 2023
barriebyron
commented
Dec 8, 2023
barriebyron
commented
Dec 8, 2023
barriebyron
commented
Dec 8, 2023
garwalsh
reviewed
Dec 8, 2023
Co-authored-by: Barrie Byron <barrie@o1labs.org>
Co-authored-by: garwalsh <gwalsh@gmail.com>
Co-authored-by: Barrie Byron <barrie@o1labs.org>
Co-authored-by: Barrie Byron <barrie@o1labs.org>
mitschabaude
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
I applied @barriebyron's suggestions and one more. Good to go from my side!
…ed single quotes from direction values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes https://app.zenhub.com/workspaces/zkapps-product-eng-6130fedb3b0fc600123d8796/issues/gh/o1-labs/docs2/733
Doc previews:
This PR includes a short overview of what gadgets are in general
A separate bitwise operations doc includes the descriptions and examples from https://github.com/o1-labs/o1js/blob/main/src/lib/gadgets/gadgets.ts
see questions in-line; thank yoU!
Includes the updated gadgets and new gadgets from o1-labs/o1js#1259