Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECDSA usage overview #785

Merged
merged 5 commits into from
Dec 19, 2023
Merged

ECDSA usage overview #785

merged 5 commits into from
Dec 19, 2023

Conversation

Trivo25
Copy link
Member

@Trivo25 Trivo25 commented Dec 15, 2023

https://docs2-git-feature-ecdsa-overview-minadocs.vercel.app/zkapps/o1js/ecdsa Adds an overview of how to use ECDSA.

There will be a separate in-depth tutorial that demonstrates how to use ECDSA and Keccak to verify Ethereum data.

@Trivo25 Trivo25 requested a review from a team as a code owner December 15, 2023 16:31
Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 9:27am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
07-oracles ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 9:27am

Base automatically changed from feature/ecdsa-keccak-overview to main December 15, 2023 18:50
If a zkApp developer wanted to verify an Ethereum transaction and make a statement about it, they would need to be able to verify the signature of the transaction. This is why ECDSA is important for zkApps.
To interact with other blockchains and verify data from the outside world, o1js needs to be able to verify signatures.
ECDSA is a widely used algorithm that is supported by many libraries and tools. For example, Ethereum transactions are signed using ECDSA over the secp256k1 curve.
As a zkApp developer, when you want to verify an Ethereum transaction and make a statement about it, you must be able to verify the signature of the transaction which is why ECDSA is important for zkApps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same style edits as Keccak, conforming to docs style guide and how we talk directly to our devs https://github.com/o1-labs/docs2/wiki/Docs-Style-Guide

Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent context and explanations for getting devs up to speed with ECDSA.

Edits for docs style to conform with how we directly talk to our developers. A few questions for you @Trivo25

docs/zkapps/o1js/ecdsa.mdx Outdated Show resolved Hide resolved

The namespace `Crypto.CurveParams` exports a few pre-defined curves, such as `Pallas`, `Vesta` and `Secp256k1`.
The namespace `Crypto.CurveParams` exports predefined curves, such as `Pallas`, `Vesta`, and `Secp256k1`.
Copy link
Contributor

@barriebyron barriebyron Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trivo25 line 46 says that o1js exports a set of predefined curves (is that automagic by default? or we need to include this code?

here we specify that it's the namespace that exports them... same? do we need both mentions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's exported under the Crypto namespace and accessible as Crypto.CurveParams if thats what you mean

@barriebyron barriebyron added docs Improvements or additions to documentation o1js labels Dec 15, 2023
Trivo25 and others added 2 commits December 19, 2023 10:22
Co-authored-by: Gregor Mitscha-Baude <gregor.mitscha-baude@gmx.at>
@garwalsh garwalsh merged commit 0130463 into main Dec 19, 2023
4 checks passed
@garwalsh garwalsh deleted the feature/ecdsa-overview branch December 19, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation o1js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants