Add missing JS binding functions #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rbonichon
commented
May 8, 2023
rbonichon
commented
- group example custom gates test functions together at the end
- provide simple int64_of_int32 missing conversion function
- add caml_fq_srs_add_lagrange_basis, whichs an updating function (no return value)
rbonichon
force-pushed
the
rb/js-bindings-missing-functions
branch
from
839ca2a
to
8c6be40
Compare
- group *_example_* custom gates test functions together at the end - provide simple int64_of_int32 missing conversion function - add caml_fq_srs_add_lagrange_basis, whichs an updating function (no return value)
rbonichon
force-pushed
the
rb/js-bindings-missing-functions
branch
from
8c6be40
to
5bb793e
Compare
|
This PR should specify what Mina / snarkyjs PR it is compatible with |
mitschabaude
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
I added a snarkyjs PR which includes these changes, to test them in CI: o1-labs/o1js#1001
querolita
approved these changes
Jun 26, 2023
|
|
||
| // Provides: integers_uint64_of_uint32 | ||
| // Requires: UInt64, caml_int64_of_int32 | ||
| function integers_uint64_of_uint32(i) { |
There was a problem hiding this comment.
Makes sense to have this converter. However, I would rather forbid the use of uint64 in the code to avoid 64bits values as wasm supports only 32bits.
|
LGTM, waiting for the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.