Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main and adapt TS bindings to develop #176

Merged
merged 248 commits into from
Oct 11, 2023
Merged

Conversation

mitschabaude
Copy link
Member

@mitschabaude mitschabaude commented Oct 9, 2023

o1js: o1-labs/o1js#1168

@mitschabaude
Copy link
Member Author

mitschabaude commented Oct 10, 2023

The linter checks seem to be using the wrong prettier config somehow. Locally, running npx prettier -c kimchi/js/**/*.js js/**/*.js works

@dannywillems
Copy link
Member

245 commits...
image
Source: https://www.youtube.com/watch?v=QglFGVDcuX8

@dannywillems
Copy link
Member

dannywillems commented Oct 10, 2023

The linter checks seem to be using the wrong prettier config somehow. Locally, running npx prettier -c kimchi/js/**/*.js js/**/*.js works

Did you try without npx? Is it not gonna get the prettier file where it finds the package.json file? In anycase, it must be fixed.

kimchi/js/bindings.js Outdated Show resolved Hide resolved
kimchi/js/bindings.js Outdated Show resolved Hide resolved
@mitschabaude
Copy link
Member Author

The linter checks seem to be using the wrong prettier config somehow. Locally, running npx prettier -c kimchi/js/**/*.js js/**/*.js works

Did you try without npx? Is it not gonna get the prettier file where it finds the package.json file? In anycase, it must be fixed.

I think the CI is wrong, not my local setup :D I can see that what my auto-formatter does corresponds to the prettier config we have (single quotes)

@dannywillems
Copy link
Member

Something important to check is if proof_create and index_create has a bytecode version.

@mitschabaude
Copy link
Member Author

Something important to check is if proof_create and index_create has a bytecode version.

Confirmed that this is the case 👍🏻

@mitschabaude
Copy link
Member Author

Fixed the lint job @dannywillems, see last commit ^^

@mitschabaude mitschabaude merged commit 256e160 into develop Oct 11, 2023
1 check passed
@mitschabaude mitschabaude deleted the merge-main-develop branch October 11, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants