Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Error: Cannot find module on Windows OS #19

Merged
merged 3 commits into from
May 10, 2023
Merged

fix Error: Cannot find module on Windows OS #19

merged 3 commits into from
May 10, 2023

Conversation

wizicer
Copy link
Contributor

@wizicer wizicer commented May 10, 2023

This patch can fix: o1-labs/o1js#896

mitschabaude
mitschabaude reviewed May 10, 2023
View reviewed changes
Copy link
Member

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contributing an important fix! just one small comment to address

js/node/node-backend.js Outdated Show resolved Hide resolved
@mitschabaude mitschabaude merged commit b39cdd7 into o1-labs:main May 10, 2023
@mitschabaude mitschabaude mentioned this pull request May 10, 2023
Merged
@ymekuria ymekuria mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module - Windows OS
2 participants
@wizicer @mitschabaude