Lower requested WASM memory for iOS user agents #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser agent to improve performance on iOS Safari devices
MartinMinkov
force-pushed
the
feat/fix-ios-safari
branch
from
baca422
to
2af2179
Compare
shimkiv
approved these changes
May 30, 2023
mitschabaude
approved these changes
May 30, 2023
There was a problem hiding this comment.
Looks good, just one comment below! I don't think this needed a change of the compiled bindings, btw, since it's only changing the JS side.
@MartinMinkov Yeah, a snarkyjs PR should just check out the submodule at the last commit of this PR. Ideally they are merged at the same time
Trivo25
approved these changes
May 30, 2023
…memory for iOS devices, as it's not necessary
MartinMinkov
force-pushed
the
feat/fix-ios-safari
branch
from
2af2179
to
efebcea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🔗 Related Issue: o1-labs/o1js#823
This pull request addresses an issue where SnarkyJS applications encounter an
Out of Memoryerror on iOS devices, specifically iPhones and iPads, while trying to initialize the WASM memory for plonk_wasm.js. This problem seems to be unique to iOS devices as desktop Safari doesn't appear to be affected.The solution involves modifying the maximum requested WASM memory for iOS user agents. Through testing, it's been found that these devices can handle up to 1GiB of requested memory. Attempting to request 2GB results in the same memory error. However, for all other user agents, the memory request remains unchanged, aiming for the maximum available, which is 4GiB.