Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error when reading variable in provable code #52

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Improve error when reading variable in provable code #52

merged 2 commits into from
Jun 22, 2023

Conversation

mitschabaude
Copy link
Member

@mitschabaude mitschabaude commented Jun 21, 2023 •
edited
Loading

companion to o1-labs/o1js#998

  • we expose inProverBlock() so we can check on the JS side whether we should throw an error or try to attempt readVar()
  • we group a few Snarky methods under a new namespace Snarky.run to not have too much stuff at the top level

@mitschabaude mitschabaude mentioned this pull request Jun 22, 2023
Merged
@mitschabaude mitschabaude marked this pull request as ready for review June 22, 2023 08:24
@mitschabaude mitschabaude merged commit f61e056 into main Jun 22, 2023
@mitschabaude mitschabaude deleted the feature/better-readvar-error branch June 22, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trivo25 Trivo25 Trivo25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mitschabaude @Trivo25