Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid code in bindings.js #56

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Fix invalid code in bindings.js #56

merged 3 commits into from
Jun 26, 2023

Conversation

mitschabaude
Copy link
Member

@mitschabaude mitschabaude commented Jun 26, 2023 •
edited
Loading

fixes invalid JS code in bindings.js. It's surprising that this even worked before.
snarkyjs CI: o1-labs/o1js#1001

@mitschabaude mitschabaude requested a review from a team as a code owner June 26, 2023 14:28
@mitschabaude mitschabaude mentioned this pull request Jun 26, 2023
Merged
Base automatically changed from rb/js-bindings-missing-functions to main June 26, 2023 15:18
@mitschabaude mitschabaude merged commit 6b069e4 into main Jun 26, 2023
@mitschabaude mitschabaude deleted the fix/bindings-js branch June 26, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@querolita querolita querolita left review comments

@dannywillems dannywillems dannywillems approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mitschabaude @dannywillems @querolita