Post refactor clean up: Split OCaml libs #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivo25
reviewed
Jun 27, 2023
ocaml/lib/snarky_js_bindings_lib.ml
Outdated
| @@ -1,58 +1,12 @@ | |||
| open Core_kernel | |||
There was a problem hiding this comment.
Nice! Should we name this file something like snarky_bindings.ml then? wdyt
There was a problem hiding this comment.
Good idea! How do you like it now? I also removed the top level Snarky module in snarky_bindings.ml now because there's nothing else in that file
Trivo25
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits up the OCaml bindings into several different files:
Snarkypickles_bindings.mlwhich exportsPickleslocal_ledger.mlwhich exportsLedgerconsistency_test.mlwhich exportsTestAlso, in support of o1-labs/o1js#1004, remove unchecked Poseidon (but keep unchecked hashToGroup as a consistency test)