Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract WasmVecVec to use it later #70

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Extract WasmVecVec to use it later #70

merged 2 commits into from
Jul 10, 2023

Conversation

dannywillems
Copy link
Member

Built on top of #69

@dannywillems
Run prettier on bindings.js
d4f9616 
Use
```
npm install -g prettier
prettier -w bindings.js
```

Initially 53b6f8b
@dannywillems
wasm/{wasm_vector, plonk_proof?: move WasmVecVecF{p,q}
e946979 
Move into wasm_vector instead of plonk_proof to reuse the structure in other
files, without depending on the whole macros
@dannywillems dannywillems requested a review from a team as a code owner July 10, 2023 11:51
@dannywillems dannywillems mentioned this pull request Jul 10, 2023
Merged
mrmr1993
mrmr1993 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dannywillems dannywillems merged commit fdd67e4 into develop Jul 10, 2023
@dannywillems dannywillems deleted the dannywillems/extract-wasmvecvec branch July 10, 2023 15:17
@dannywillems dannywillems mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dannywillems @mrmr1993