Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all example zkApps inside src/examples, ensure they can all build and execute correctly #1222

Closed
MartinMinkov opened this issue Nov 2, 2023 · 4 comments · Fixed by #1240
Labels
good first issue Good for newcomers

Comments

@MartinMinkov
Copy link
Contributor

MartinMinkov commented Nov 2, 2023

Summary

Some examples in https://github.com/o1-labs/o1js/tree/main/src/examples fail to build when running npm run build:examples. I'd guess that all these errors are because they were assuming an older version of o1js and never updated their APIs. It would be great to get these to build and run again since they are a beneficial resource when everything is up to date.

@MartinMinkov MartinMinkov added the good first issue Good for newcomers label Nov 2, 2023
@barriebyron
Copy link
Contributor

Contributor guidance, submit one PR for each example file

@mitschabaude
Copy link
Member

Contributor guidance, submit one PR for each example file

Note: as there are a lot of examples, and many fixes will be trivial, I don't recommend to take that too literally

@dfstio
Copy link

dfstio commented Nov 29, 2023

It would also be great to publish the examples to some sandbox site like https://stackblitz.com and add links to the sandbox code to the Tutorials docs.

@ymekuria
Copy link
Contributor

It would also be great to publish the examples to some sandbox site like https://stackblitz.com and add links to the sandbox code to the Tutorials docs.

Great idea! We are exploring ways to incorporate something like this.

@mitschabaude mitschabaude linked a pull request Dec 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants