♻️ Updated and tested the examples after the renaming of preconditions #1247 #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Gregor, This PR is failed because our first PR #1265 is yet to be merged. Thank You 😃 |
|
Hi @mitschabaude , Thanks for merging the previous PR. |
mitschabaude
approved these changes
Nov 27, 2023
|
Great to see your contribution completed @LuffySama-Dev, thanks for helping out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mitschabaude ,
Good Day!!
As discussed here, I have tested and modified the examples in
src/examples.Can you please help to review and approve this pull request.
I guess this PR will also solve this issue #1222
Issues resolved by this PR:
#1247
#1222
Note:
I need your help with testing
simple_zkapp_berkeley.ts, as it is giving this error:I tried to update and test
commonjs.cjsfile too. It also fail during testing.If required I can provide screenshots of test results too.
Thank You 😃