Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - Fetched events can have incorrect transaction IDs if the events are emitted in different AccountUpdates #806

Closed
MartinMinkov opened this issue Mar 23, 2023 · 0 comments · Fixed by #825
Assignees
Labels
bug Something isn't working

Comments

@MartinMinkov
Copy link
Contributor

Description

fetchEvents uses the Archive Node API to fetch events/actions from the Archive Node. When fetchEvents were implemented, the internal type of Events was updated to reflect network information such as block and transaction information.

Due to a bug in the Archive Node API, events have incorrect transaction information. Actions are not affected in this case since actions do not have transaction information fetched from the API. Only events do.

Currently, in SnarkyJS, the return value of fetchEvents is incorrect since transaction information should be defined for each event. To fix, we need to change the GraphQL query for fetchEvents and change the internal types used in SnarkyJS to add transaction information to events instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants