Change fetchEvents to return transactionInfo inside events type #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
馃敆 Related Issue: #806
This PR addresses an issue with the internal event type in SnarkyJS. Previously, the event handling assumed that all events were contained within the same zkApp transaction, which isn't always true. Events can be emitted in different zkApp transactions, and multiple zkApp transactions can be present within a block.
To resolve this, we have updated the internal event type to include event data and transaction information as separate objects. This allows us to provide accurate information about each event, taking into account the specific transaction it belongs to.
Please note that there is a related PR for the Archive Node API, which can be found here: o1-labs/Archive-Node-API#68
Both PRs should be merged simultaneously to ensure proper coordination and integration.