Add ZkProgram name as required argument #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinMinkov
approved these changes
Oct 26, 2023
| @@ -273,7 +275,7 @@ function ZkProgram< | |||
| let publicInputType: ProvablePure<any> = config.publicInput! ?? Undefined; | |||
| let publicOutputType: ProvablePure<any> = config.publicOutput! ?? Void; | |||
|
|
|||
| let selfTag = { name: `Program${i++}` }; | |||
| let selfTag = { name: config.name }; | |||
There was a problem hiding this comment.
Do we want to sanitize this input in any way since this will be written to disk? Some thoughts that come to mind:
- Safe encoding (making sure only alphanumeric characters and separators are specified)
- String length
These are just some thoughts, it's entirely up to you if you find them appropriate :D
There was a problem hiding this comment.
Yes very appropriate! I'll figure it out in the caching PR, maybe serialize them before using as filename but leave the name string on the ZkProgram in original form
|
oh thanks to Maki for noticing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
nameargument to ZkProgram.nameis required in the new non-experimental API, but still optional in the oldExperimental.ZkProgram