Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreign fields 4: Multiplication #1223

Merged
merged 37 commits into from
Nov 21, 2023
Merged

Foreign fields 4: Multiplication #1223

merged 37 commits into from
Nov 21, 2023

Commits on Nov 2, 2023

  1. ffmul gate wrapper

    @mitschabaude
    mitschabaude committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    959cac2 View commit details
    Browse the repository at this point in the history

  2. ffmul witnesses

    @mitschabaude
    mitschabaude committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7dab788 View commit details
    Browse the repository at this point in the history

  3. raw gate wrapper

    @mitschabaude
    mitschabaude committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    99628cb View commit details
    Browse the repository at this point in the history

  4. ffmul constraints

    @mitschabaude
    mitschabaude committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    409c73a View commit details
    Browse the repository at this point in the history

  5. constant case

    @mitschabaude
    mitschabaude committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8f58577 View commit details
    Browse the repository at this point in the history

  6. start testing

    @mitschabaude
    mitschabaude committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    283fbd6 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. another small witness test

    @mitschabaude
    mitschabaude committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    fb28f88 View commit details
    Browse the repository at this point in the history

  2. add proof mul test which doesn't work

    @mitschabaude
    mitschabaude committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    ee17ca3 View commit details
    Browse the repository at this point in the history

  3. revert test to normal

    @mitschabaude
    mitschabaude committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    cff7732 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. refactor common mul logic into function

    @mitschabaude
    mitschabaude committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    b6bdf13 View commit details
    Browse the repository at this point in the history

  2. ff inverse

    @mitschabaude
    mitschabaude committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d0f592d View commit details
    Browse the repository at this point in the history

  3. fix inverse

    @mitschabaude
    mitschabaude committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    b403745 View commit details
    Browse the repository at this point in the history

  4. division

    @mitschabaude
    mitschabaude committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    f7e2fe4 View commit details
    Browse the repository at this point in the history

  5. improve zkprogram analyzemethods return

    @mitschabaude
    mitschabaude committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    4d8c4e1 View commit details
    Browse the repository at this point in the history

  6. fix division

    @mitschabaude
    mitschabaude committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    ca0f39a View commit details
    Browse the repository at this point in the history

  7. test inv and div

    @mitschabaude
    mitschabaude committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    16d8dc4 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Merge branch 'feature/ffadd' into feature/ffmul

    @mitschabaude
    mitschabaude committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    1295155 View commit details
    Browse the repository at this point in the history

  2. minor

    @mitschabaude
    mitschabaude committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    aa8c8f4 View commit details
    Browse the repository at this point in the history

  3. add cs tests for mul

    @mitschabaude
    mitschabaude committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    96f52da View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. fix: add missing mrc

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    3bfdc09 View commit details
    Browse the repository at this point in the history

  2. introduce assertmul and use it for inv and div

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    67d706e View commit details
    Browse the repository at this point in the history

  3. add ff tests with unreduced inputs

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e100923 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/ffmul' of github.com:o1-labs/o1js into feature/… 

    …ffmul
    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    2b9ca3f View commit details
    Browse the repository at this point in the history

  5. a bit of clean up

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f40104c View commit details
    Browse the repository at this point in the history

  6. remove unused logic

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    4f1b21f View commit details
    Browse the repository at this point in the history

  7. add to gadgets namespace, mul doccomment

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    4532a21 View commit details
    Browse the repository at this point in the history

  8. fix unit tests and code tweak

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    8358f57 View commit details
    Browse the repository at this point in the history

  9. document inv and div

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    21b9e8b View commit details
    Browse the repository at this point in the history

  10. bindings

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e46432d View commit details
    Browse the repository at this point in the history

  11. minor

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    df2ea58 View commit details
    Browse the repository at this point in the history

  12. minor tweaks + changelog

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    9d6bb6d View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. fix: don't range-check 2-bit carry

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    0ccea11 View commit details
    Browse the repository at this point in the history

  2. consistent lower-casing of limb size constant

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    571866b View commit details
    Browse the repository at this point in the history

  3. remove remainder bounds check in mul() gadget

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    91fef76 View commit details
    Browse the repository at this point in the history

  4. fixup unit test

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    ccb55c7 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Merge branch 'main' into feature/ffmul

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    976f212 View commit details
    Browse the repository at this point in the history

  2. address feedback

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    021b001 View commit details
    Browse the repository at this point in the history