Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECDSA gadget #1240

Merged
merged 114 commits into from
Dec 6, 2023
Merged

ECDSA gadget #1240

merged 114 commits into from
Dec 6, 2023

Commits on Nov 15, 2023

  1. double

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    6c34c9f View commit details
    Browse the repository at this point in the history

  2. tweak cs printing

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    d41f30f View commit details
    Browse the repository at this point in the history

  3. initial aggregator for scaling

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    4c3f6a5 View commit details
    Browse the repository at this point in the history

  4. another helper method on Field3

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    c99cee2 View commit details
    Browse the repository at this point in the history

  5. add constant ecdsa implementation and helper types

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    95017b3 View commit details
    Browse the repository at this point in the history

  6. bindings

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    dd2ebd3 View commit details
    Browse the repository at this point in the history

  7. helper

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    fc6f1f8 View commit details
    Browse the repository at this point in the history

  8. stub out provable ecdsa, skipping the hard part

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    00a11f7 View commit details
    Browse the repository at this point in the history

  9. revert explosion of helper methods in favor of general interface

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ce389ef View commit details
    Browse the repository at this point in the history

  10. add constant cases and a bit more ecdsa logic

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e458907 View commit details
    Browse the repository at this point in the history

  11. bindings

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    8db8d06 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. implement ecdsa

    @mitschabaude
    mitschabaude committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ab9584f View commit details
    Browse the repository at this point in the history

  2. signature from hex

    @mitschabaude
    mitschabaude committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    c39e0f8 View commit details
    Browse the repository at this point in the history

  3. add ecdsa test script

    @mitschabaude
    mitschabaude committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    b924cad View commit details
    Browse the repository at this point in the history

  4. move initial ec testing code

    @mitschabaude
    mitschabaude committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    9a2629f View commit details
    Browse the repository at this point in the history

  5. fix bit slicing logic

    @mitschabaude
    mitschabaude committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    a1370e8 View commit details
    Browse the repository at this point in the history

  6. bindings

    @mitschabaude
    mitschabaude committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    92318fe View commit details
    Browse the repository at this point in the history

  7. several fixes to the scaling algorithm, debugging

    @mitschabaude
    mitschabaude committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    92a627e View commit details
    Browse the repository at this point in the history

  8. fix uneven window sizes by glueing together overlapping chunk between… 

    … limbs
    @mitschabaude
    mitschabaude committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    cc4f9b1 View commit details
    Browse the repository at this point in the history

  9. remove debug logs

    @mitschabaude
    mitschabaude committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    90d341f View commit details
    Browse the repository at this point in the history

  10. fixup

    @mitschabaude
    mitschabaude committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    e7b8d23 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. fix

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f7c5176 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/ffmul' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    a4f5638 View commit details
    Browse the repository at this point in the history

  3. adapt to ffmul changes

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    968a5ae View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/ffmul' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    1129739 View commit details
    Browse the repository at this point in the history

  5. bound y (needed for doubling)

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9b29f40 View commit details
    Browse the repository at this point in the history

  6. tweak initial aggregator

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    38b9b7f View commit details
    Browse the repository at this point in the history

  7. bindings

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    69a814d View commit details
    Browse the repository at this point in the history

  8. remove unused function

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    be15bf1 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'feature/ffmul' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b025198 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. generalize doubleScalarMul to multiScalarMul to deduplicate logic

    @mitschabaude
    mitschabaude committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    c0f297d View commit details
    Browse the repository at this point in the history

  2. save >3k constraints by optimizing array get gadget

    @mitschabaude
    mitschabaude committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    241aae1 View commit details
    Browse the repository at this point in the history

  3. clean up table logic

    @mitschabaude
    mitschabaude committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    f4801d0 View commit details
    Browse the repository at this point in the history

  4. optimal window size changed

    @mitschabaude
    mitschabaude committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    80dbef6 View commit details
    Browse the repository at this point in the history

  5. replace mul input rcs with generic gates

    @mitschabaude
    mitschabaude committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    73d2b2d View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. enable strict typing of variable fields

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    21050b6 View commit details
    Browse the repository at this point in the history

  2. optimized assertOneOf gadget

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    89e0cdd View commit details
    Browse the repository at this point in the history

  3. simplify low-level gadgets

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    d0a3159 View commit details
    Browse the repository at this point in the history

  4. make new assertRank1 more efficient and enable it

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    64610e7 View commit details
    Browse the repository at this point in the history

  5. expose assertMul and Sum

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    eacc1e6 View commit details
    Browse the repository at this point in the history

  6. adapt elliptic curve gadget

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    003f29d View commit details
    Browse the repository at this point in the history

  7. add assertion to prevent invalid multiplication

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    347524a View commit details
    Browse the repository at this point in the history

  8. document assertMul

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    24a0bf6 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Merge branch 'feature/assert-mul' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    3969ccd View commit details
    Browse the repository at this point in the history

  2. some API and comment tweaks

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    569e1c6 View commit details
    Browse the repository at this point in the history

  3. code moving

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a4b1137 View commit details
    Browse the repository at this point in the history

  4. bindings

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    ea17473 View commit details
    Browse the repository at this point in the history

  5. adapt to bindings

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    2898db3 View commit details
    Browse the repository at this point in the history

  6. fields on curve

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    9fd2353 View commit details
    Browse the repository at this point in the history

  7. ecdsa sign

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    3e9ee6b View commit details
    Browse the repository at this point in the history

  8. adapt

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c501bad View commit details
    Browse the repository at this point in the history

  9. bindings

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    321f963 View commit details
    Browse the repository at this point in the history

  10. fix test compilation

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c705ed5 View commit details
    Browse the repository at this point in the history

  11. map rng pf spec

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    9d48098 View commit details
    Browse the repository at this point in the history

  12. wip quick ecdsa tests

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    5780bfe View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. finish unit test

    @mitschabaude
    mitschabaude committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4fee529 View commit details
    Browse the repository at this point in the history

  2. clean up constant ecdsa

    @mitschabaude
    mitschabaude committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    b35bf20 View commit details
    Browse the repository at this point in the history

  3. comment

    @mitschabaude
    mitschabaude committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    3369ae3 View commit details
    Browse the repository at this point in the history

  4. api cleanup

    @mitschabaude
    mitschabaude committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    cf27df5 View commit details
    Browse the repository at this point in the history

  5. comments and make sure r,s are valid

    @mitschabaude
    mitschabaude committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    bf6d2e9 View commit details
    Browse the repository at this point in the history

  6. fix

    @mitschabaude
    mitschabaude committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4bb7b1a View commit details
    Browse the repository at this point in the history

  7. sketch public API

    @mitschabaude
    mitschabaude committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    415f8ae View commit details
    Browse the repository at this point in the history

  8. bindings

    @mitschabaude
    mitschabaude committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    a9e75e8 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. add helper to apply all ff range checks

    @mitschabaude
    mitschabaude committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    b451ebe View commit details
    Browse the repository at this point in the history

  2. add more documentation

    @mitschabaude
    mitschabaude committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    d891330 View commit details
    Browse the repository at this point in the history

  3. use range check helper in ec gadgets

    @mitschabaude
    mitschabaude committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    697ddb3 View commit details
    Browse the repository at this point in the history

  4. add tests

    @mitschabaude
    mitschabaude committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    86da890 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Merge branch 'main' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5e4e0a4 View commit details
    Browse the repository at this point in the history

  2. expose ecdsa types

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    206440d View commit details
    Browse the repository at this point in the history

  3. start ecdsa example

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    8aff97a View commit details
    Browse the repository at this point in the history

  4. expose elliptic curve intf on new Crypto namespace

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    05925b2 View commit details
    Browse the repository at this point in the history

  5. finish example

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    89f7d01 View commit details
    Browse the repository at this point in the history

  6. make vk returned by zkprogram consistent with smart contract

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2094f68 View commit details
    Browse the repository at this point in the history

  7. changelog

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9ad5794 View commit details
    Browse the repository at this point in the history

  8. changelog

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e7efc5d View commit details
    Browse the repository at this point in the history

  9. fix: use a variable for public key when analyzing ecdsa constraints

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e0c43f7 View commit details
    Browse the repository at this point in the history

  10. add vk regression test for ecdsa

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a2fe70f View commit details
    Browse the repository at this point in the history

  11. expose cs printing

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    665158b View commit details
    Browse the repository at this point in the history

  12. minor

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    71b7dcf View commit details
    Browse the repository at this point in the history

  13. delete ec unit test

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    febd9c9 View commit details
    Browse the repository at this point in the history

  14. changelog

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f27f2e1 View commit details
    Browse the repository at this point in the history

  15. finish doccomments

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    191971d View commit details
    Browse the repository at this point in the history

  16. bindings

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    6a449b2 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'feature/assert-mul' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    16f0c0a View commit details
    Browse the repository at this point in the history

  18. fix unit test

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    d0dc254 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. move todo out of doccomment

    @mitschabaude
    mitschabaude committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    e7ad795 View commit details
    Browse the repository at this point in the history

  2. return a bool from verify()

    @mitschabaude
    mitschabaude committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    660f1a4 View commit details
    Browse the repository at this point in the history

  3. update vk

    @mitschabaude
    mitschabaude committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    1a55a5d View commit details
    Browse the repository at this point in the history

  4. wip adapting ecdsa soundness to bool return

    @mitschabaude
    mitschabaude committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    57576fa View commit details
    Browse the repository at this point in the history

  5. cherry pick assertLessThan

    @mitschabaude
    mitschabaude committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    5f5cd31 View commit details
    Browse the repository at this point in the history

  6. finish adapting ecdsa final step

    @mitschabaude
    mitschabaude committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    af6de47 View commit details
    Browse the repository at this point in the history

  7. update vk

    @mitschabaude
    mitschabaude committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c193bd7 View commit details
    Browse the repository at this point in the history

  8. document config

    @mitschabaude
    mitschabaude committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    66a9dc1 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Merge branch 'main' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    2731b0c View commit details
    Browse the repository at this point in the history

  2. foreign field: split assert non zero into function

    @mitschabaude
    mitschabaude committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    1ad2602 View commit details
    Browse the repository at this point in the history

  3. assertNotEquals -> equals

    @mitschabaude
    mitschabaude committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    1c90b52 View commit details
    Browse the repository at this point in the history

  4. fix final check in scalar mul

    @mitschabaude
    mitschabaude committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    7886bef View commit details
    Browse the repository at this point in the history

  5. split out equals

    @mitschabaude
    mitschabaude committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ba0c361 View commit details
    Browse the repository at this point in the history

  6. vk update

    @mitschabaude
    mitschabaude committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    dba58f3 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Merge branch 'feature/assert-mul' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    9c3c653 View commit details
    Browse the repository at this point in the history

  2. apply small review suggestions

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d0b09b9 View commit details
    Browse the repository at this point in the history

  3. support for a!=0 in double gadget

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    f68c148 View commit details
    Browse the repository at this point in the history

  4. move ff equals gadget and handle an edge case

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    124d918 View commit details
    Browse the repository at this point in the history

  5. rename assertAlmostFieldElements

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    2495901 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    4999fe8 View commit details
    Browse the repository at this point in the history

  7. fixup vk test

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    6fc4e86 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    f5ab9bc View commit details
    Browse the repository at this point in the history

  9. fixups

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    621d2ef View commit details
    Browse the repository at this point in the history

  10. Merge branch 'feature/assert-mul' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    e2b0dd6 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Merge branch 'main' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    450203e View commit details
    Browse the repository at this point in the history

  2. remove gadgets.ecdsa which ended up in a different final form

    @mitschabaude
    mitschabaude committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    f51e5c0 View commit details
    Browse the repository at this point in the history

  3. fix build:examples while we're here

    @mitschabaude
    mitschabaude committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    bbcfb17 View commit details
    Browse the repository at this point in the history

  4. remove ecdsa from vk test for now

    @mitschabaude
    mitschabaude committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    7ec8090 View commit details
    Browse the repository at this point in the history

  5. fixup

    @mitschabaude
    mitschabaude committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    507a04b View commit details
    Browse the repository at this point in the history