Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreign fields 5: Optimized multiplication of sums #1262

Merged
merged 41 commits into from
Dec 6, 2023
Merged

Foreign fields 5: Optimized multiplication of sums #1262

merged 41 commits into from
Dec 6, 2023

Commits on Nov 10, 2023

  1. start ec add

    @mitschabaude
    mitschabaude committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    dfed701 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. much more efficient ecadd

    @mitschabaude
    mitschabaude committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    d50cd01 View commit details
    Browse the repository at this point in the history

  2. chain add into mul

    @mitschabaude
    mitschabaude committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    b7fccab View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Merge branch 'feature/ffmul' into feature/ecdsa-new

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    bd8785e View commit details
    Browse the repository at this point in the history

  2. adapt to ffmul updates

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    d27cc07 View commit details
    Browse the repository at this point in the history

  3. replace custom logic in ec add with easy to use assertRank1 method

    @mitschabaude
    mitschabaude committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    b19a3f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. delete ec gadget from this branch

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    a88276c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/assert-mul

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    efae7cf View commit details
    Browse the repository at this point in the history

  3. adapt to main

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    b2cada8 View commit details
    Browse the repository at this point in the history

  4. replace mul input rcs with generic gates

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ccb9246 View commit details
    Browse the repository at this point in the history

  5. enable strict typing of variable fields

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    554f37a View commit details
    Browse the repository at this point in the history

  6. optimized assertOneOf gadget

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    e7c1791 View commit details
    Browse the repository at this point in the history

  7. make new assertRank1 more efficient and enable it

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    1a72bfc View commit details
    Browse the repository at this point in the history

  8. expose assertMul and Sum

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    0ed257a View commit details
    Browse the repository at this point in the history

  9. add assertion to prevent invalid multiplication

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    9647ac8 View commit details
    Browse the repository at this point in the history

  10. document assertMul

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    fe166c0 View commit details
    Browse the repository at this point in the history

  11. start writing unit test

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    e647ae4 View commit details
    Browse the repository at this point in the history

  12. handle constant case in Sum

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ab198f5 View commit details
    Browse the repository at this point in the history

  13. another helper method on Field3

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    a76c8c8 View commit details
    Browse the repository at this point in the history

  14. constant case in assertMul

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    188c477 View commit details
    Browse the repository at this point in the history

  15. add some tests for cs

    @mitschabaude
    mitschabaude committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    bedae7a View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. more cs test

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    7ee955e View commit details
    Browse the repository at this point in the history

  2. tweak cs printing

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    3d357c5 View commit details
    Browse the repository at this point in the history

  3. add reasoning for constraint reductions

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    7db3187 View commit details
    Browse the repository at this point in the history

  4. simplify low-level gadgets

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    12c227b View commit details
    Browse the repository at this point in the history

  5. comments

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    5f53f1c View commit details
    Browse the repository at this point in the history

  6. changelog

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    cc0220e View commit details
    Browse the repository at this point in the history

  7. comments, improve var naming

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    4373bb3 View commit details
    Browse the repository at this point in the history

  8. unconstrained provable

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    aedd9eb View commit details
    Browse the repository at this point in the history

  9. better unconstrained provable

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    152083b View commit details
    Browse the repository at this point in the history

  10. allow passing .provable to methods

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    b49af92 View commit details
    Browse the repository at this point in the history

  11. test unconstrained

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    d26dab9 View commit details
    Browse the repository at this point in the history

  12. merge provable and witness computation using unconstrained

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    90941ac View commit details
    Browse the repository at this point in the history

  13. document and export Unconstrained

    @mitschabaude
    mitschabaude committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    8104806 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Merge branch 'main' into feature/assert-mul

    @mitschabaude
    mitschabaude committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5f8c568 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Merge branch 'main' into feature/assert-mul

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    130ab28 View commit details
    Browse the repository at this point in the history

  2. bindings

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    7b80728 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/assert-mul

    @mitschabaude
    mitschabaude committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    a3a5390 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. address misc feedback

    @mitschabaude
    mitschabaude committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    ea98308 View commit details
    Browse the repository at this point in the history

  2. add negative unit test

    @mitschabaude
    mitschabaude committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    74ff146 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/assert-mul

    @mitschabaude
    mitschabaude committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    ef27caf View commit details
    Browse the repository at this point in the history