-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ECDSA + Keccak #1307
Integrate ECDSA + Keccak #1307
Conversation
closes #61 |
@@ -1,31 +1,23 @@ | |||
import { Field } from './field.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, does this fit into src/lib/gadgets
better than src/lib
? Similar to ECDSA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably does! IIRC, I put it there before ECDSA was done, but it should probably live wherever that lives!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I can move it in the later PR!
Changes
sponge()
function was rewritten with the assumption thatlength
andcapacity
are multiples of 64 bits 😬 With a bit of extra work it should be possible to bring back 224 and keep constraints optimal. Honestly, I doubt 224 will be needed.sign()
andverify()
to take message bytes and do the Keccak hashTODOs not covered by this PR
UInt8
as a safe input to Keccak / ECDSA as in Add new hashing functions (SHA & Keccak) #999Results