Use HashInput packing for computing call data
#1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function checks if an object has 'toInput' and 'empty' methods, which are necessary for an object to be hashable. This will help in validating objects before attempting to hash them, preventing potential runtime errors.
…ability and maintainability The computeCallData function has been refactored to improve its readability and maintainability. The changes include reordering the code blocks and removing unnecessary comments. The totalArgSize and returnSize are now calculated and appended in a more logical order. This refactoring does not affect the functionality of the code but makes it easier to understand and maintain.
This method is the implementation of `ProvableExtended.toInput()` for the `Field` type. It returns an object where the `fields` key is a `Field` array of length 1 created from this `Field`. This is mainly for internal use and not intended for zkApp developers.
…ccountUpdate.callData computation This update includes details about a significant reduction in the number of constraints used when inputs to a zkApp method are many field elements.
…st build is used for regression tests
…ion from Field to Scalar for accuracy
MartinMinkov
force-pushed
the
feat/calldata-hashing-perf
branch
from
de2e7ae
to
9ce4ea6
Compare
mitschabaude
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses
toInputandHashInputto more efficiently compute call data. This helps when we have method inputs that can be packed into smaller field elements, which leads to less hashing and fewer constraints generated 🎉