-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Efficient comparisons #1523
Merged
Merged
Efficient comparisons #1523
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
9c6fa34
bigint assert less than
mitschabaude e274fcd
bigint assert less than or equal
mitschabaude ffae661
unit tests for comparison assertions
mitschabaude 0af69c1
helper in field stub module
mitschabaude 41f75d1
more efficient comparison assertions which are generic over the range
mitschabaude ea60f08
refine assumptions of comparison gadget
mitschabaude 9b5c337
use generic comparison assertion for uint, improve efficiency
mitschabaude 79e610d
generic boolean comparisons
mitschabaude 65e21bd
use generic boolean comparison for field
mitschabaude 71a1b0d
use generic boolean comparisons for uint, improve efficiency
mitschabaude 8726900
full field comparison
mitschabaude 34bbd56
fixup uint lessthan
mitschabaude 17fbdb6
get rid of circular dependencies from using foreign field gadgets for…
mitschabaude 49f04f1
constant spec
mitschabaude 53e5b11
make failing foreign field additions throw, so we can trust unit tests
mitschabaude 9e2357c
full less than or equal
mitschabaude e703bdd
use full comparison assertions for field, massive efficiency gain
mitschabaude 87be871
full boolean comparisons
mitschabaude 1b80114
use full boolean comparisons
mitschabaude 9531b51
remove 253-bits limitation from tests and docs
mitschabaude 9606b23
fix edge case in bigint assert less than
mitschabaude 76f261c
explicit unsafe bool creation and optimization for constants
mitschabaude 10138fa
more efficient isEven that always works; assertBool returns a Bool
mitschabaude f04c396
it was a lovely trick, but this is more efficient
mitschabaude af78122
fixup diverse zkprogram types
mitschabaude 9a362d2
use fast isOdd gadget in signature gadgets
mitschabaude 0b56545
cleanup and changelog
mitschabaude a7808e2
final changelog tweaks
mitschabaude b973423
bindings
mitschabaude d2dc857
force recompile changes the vk
mitschabaude 5348010
unrelated: fix ./run-in-browser on scripts that import o1js
mitschabaude e15f77d
typos
mitschabaude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!