Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use MerkleList for reducer #1577

Merged
merged 44 commits into from
Apr 18, 2024
Merged

use MerkleList for reducer #1577

merged 44 commits into from
Apr 18, 2024

Conversation

Trivo25
Copy link
Member

@Trivo25 Trivo25 commented Apr 14, 2024

on top of #1562

@Trivo25 Trivo25 changed the base branch from main to breaking-reducer April 14, 2024 12:34
Trivo25 and others added 28 commits April 14, 2024 14:38
@Trivo25
fix example
9498a7b
@Trivo25
temp working
1b92f0a
@Trivo25
add row counter
f3f8306
@mitschabaude
reduce reducer work
90d28b0
@mitschabaude
delete later: constraints investigation file
1fec588
@mitschabaude
fix
445cf27
@mitschabaude
this seems enough
0b1c446
@mitschabaude
change from hacky next override to previous()
66f6fdc
@mitschabaude
comment
f4c2c40
@mitschabaude
unsafe iteration
afa0434
@mitschabaude
even more unsafe actions iteration
8c1c2dc
@mitschabaude
better dummy protection
7da81a8
@mitschabaude
i think this is close to equivalent to the old logic
6d3a4c0
@mitschabaude
delete testing file
5122aff
@mitschabaude
revert moving isDummy out of the circuit, this isn't safe here
1eb08df
@mitschabaude
minor
46c6c1d
@mitschabaude
better =1 case
3e8cead
@mitschabaude
api tweak and docs
5e12b8a
@mitschabaude
Merge branch 'breaking-reducer' into reducer-v1-prep
e66c061
@mitschabaude
fix merge conflict and next()
ca5c26c
@mitschabaude
reverse unsafe stepping functions
27fe476
@mitschabaude
reverse reduce impl
901a3de
@mitschabaude
collapse prover blocks
16d2d92
@mitschabaude
minor
f6d7a9e
@mitschabaude
Merge branch 'main' into reducer-v1-prep
9c1ea70
@mitschabaude
fixup
da6da5d
@mitschabaude
Merge branch 'breaking-reducer' into reducer-v1-prep
172e96d
@mitschabaude
fix examples build and fetchActions input type
7722248
Base automatically changed from breaking-reducer to main April 18, 2024 12:10
@mitschabaude mitschabaude marked this pull request as ready for review April 18, 2024 15:47
@mitschabaude mitschabaude mentioned this pull request Apr 18, 2024
Draft
@Trivo25 Trivo25 merged commit cd428b6 into main Apr 18, 2024
14 checks passed
@Trivo25 Trivo25 deleted the reducer-v1-prep branch April 18, 2024 20:34
@Trivo25 Trivo25 restored the reducer-v1-prep branch April 24, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Trivo25 @mitschabaude