Add testing spec for int.ts file #164
Conversation
There was a problem hiding this comment.
Wow a lot of test cases, nice!
- Can you make issues all the failing tests?
- Is there some way we can test the circuits too? I think right now we're testing the "outside the circuit" version of the logic. We may need to do some crazy ocaml stuff in order to do constraint checking without proof generation (this will be fast, but still catch errors) -- maybe @mitschabaude already knows if this is exposed?
src/lib/int.test.ts
Outdated
| afterAll(async () => { | ||
| setTimeout(async () => { | ||
| await shutdown(); | ||
| }, 1500); |
There was a problem hiding this comment.
why is there a long timeout here before we shutdown?
There was a problem hiding this comment.
Replaced this with a timeout of 0. The reason we use a timeout at all is that await shutdown() calls process.exit() under the hood and introduces a race condition with the Jest output and just shutting down the running process. By using a timeout of 0, we can defer the await shutdown until everything else in the tests is done executing and it doesn't cut off the test output.
There was a problem hiding this comment.
SetTimeout 0 as a defer seems okay to me 👍
|
Oh wow, so many failure cases! This is great to have.
I agree that we'd like to have some in-snark testing as well. There's |
MartinMinkov
force-pushed
the
feature/more-tests
branch
from
99c1c51
to
50c2343
Compare
Description
Adds initial test spec for all classes in the
int.tsfile. This includesInt64,UInt64, andUInt32.There are a number of bugs uncovered while writing unit tests for these classes, some are documented as issues and others are not. I will be looking through our issues list and adding bugs that are not currently present.
The current tests that fail due to bugs are commented out with their error message as a comment. If one wishes to inspect further, uncomment the test and run
npm run test