Enforce state preconditions #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkase
approved these changes
Jun 28, 2022
| if (!context?.wasRead || context.wasConstrained) continue; | ||
| // we accessed a precondition field but not constrained it explicitly - throw an error | ||
| let errorMessage = `You used \`this.${key}.get()\` without adding a precondition that links it to the actual on-chain state. | ||
| Consider adding this line to your code: |
There was a problem hiding this comment.
Great error message :D
| this._contract.wasConstrained = true; | ||
| }, | ||
|
|
||
| assertNothing() { |
There was a problem hiding this comment.
Quick question, when is assertNothing intended to be used?
There was a problem hiding this comment.
No specific use case I had in mind, I just wanted to have an escape hatch to get rid of the error if you have some reason to use .get() without having a precondition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code that looked like this:
will throw an error, and has to be changed to look like this:
this makes it consistent with the behaviour for other preconditions (#179)