Sequencing events #274

mitschabaude · 2022-07-06T17:00:54Z

Closes Sequencing support (a.k.a. sequence events) #88
RFC: Sequence Events RFC #265

mitschabaude · 2022-07-07T19:57:54Z

src/lib/circuit_value.ts

@@ -467,3 +469,39 @@ function circuitValueEquals<T>(a: T, b: T): boolean {
    ([key, value]) => key in b && circuitValueEquals((b as any)[key], value)
  );
 }
+
+function pickOne<T, A extends AsFieldElements<T>>(


handy function that I needed for the dynamic length stuff, and exported as Circuit.pickOne. A less general version was previously in string.ts

mitschabaude · 2022-07-07T20:02:51Z

src/lib/mina.ts

@@ -254,7 +256,21 @@ function LocalBlockchain({
      return { wait: async () => {} };
    },
    async transaction(sender: SenderSpec, f: () => void) {
-      return createTransaction(sender, f);
+      // bad hack: run transaction just to see whether it creates proofs
+      // if it doesn't, this is the last chance to run SmartContract.runOutsideCircuit, which is supposed to run only once


I introduced SmartContract.runOutsideCircuit for an earlier version of the state rollup example, where I needed to take values from the @method run and store them outside. It was pretty hacky to get that working -- e.g. it's important that this runs only once (in the "user expectation" sense of "once"). Left it in the API since it may be useful another time and could get much less hacky with the some planned changes (parties-returning and async-method-running)

mitschabaude · 2022-07-07T20:05:31Z

src/lib/zkapp.ts

+        );
+      }
+      let methodData = contract.analyzeMethods();
+      let possibleUpdatesPerTransaction = [


one of the magical things this function does is it knows how many events each of the smart contract methods emits, so it can perform computations for each of those numbers-of-events and then pick the actual one.
to enable that, I added SmartContract.analyzeMethods in this file and synthesizeMethodArguments in proof_systems.ts

mitschabaude · 2022-07-07T20:06:23Z

src/lib/zkapp.ts

+  };
+};
+
+function getStateUpdate<S, U>(


here and below is where the stateUpdate API is actually implemented!

bkase

This still needs updating to the latest version of the RFC before we should land it even under the "experimental" flag -- and don't forget to change the names of things everywhere! I stopped mentioning it after I realized you haven't updated this yet.

bkase · 2022-07-13T23:59:03Z

src/lib/circuit_value.ts

@@ -467,3 +469,39 @@ function circuitValueEquals<T>(a: T, b: T): boolean {
    ([key, value]) => key in b && circuitValueEquals((b as any)[key], value)
  );
 }
+
+function pickOne<T, A extends AsFieldElements<T>>(


maybe this should be select or switch or case? pickOne doesn't feel right to me

switch is great -- analogous to Circuit.if

bkase · 2022-07-14T00:00:24Z

src/examples/state_update_rollup.ts

+  // version that's implicitly represented by the list of updates
+  @state(Field) counter = State<Field>();
+  // helper field to store the point in the update history that our on-chain state is at
+  @state(Field) stateHash = State<Field>();


let's change this to whatever you pick on the RFC-side like actionsHash or actionsCommitment

bkase · 2022-07-14T00:00:50Z

src/examples/state_update_rollup.ts

+    this.stateUpdate.emit(increment);
+  }
+
+  @method rollupStateUpdate() {


bkase · 2022-07-14T00:01:42Z

src/lib/circuit_value.test.ts

@@ -0,0 +1,15 @@
+import { Bool, Circuit, isReady, shutdown, Int64 } from '../../dist/server';
+
+describe('circuit', () => {


can you add tests expecting failures if there are more than one true and zero true?

done. for some reason returning 0 for zero true seemed natural to me. but I can also throw in that case if you think that's better

good point yeah 0 is fine, but can you add a test for the zero case succeeding too?

bkase · 2022-07-14T16:30:40Z

src/examples/state_update_rollup.ts

+if (doProofs) await tx.prove();
+tx.send();
+// update internal state
+pendingActions.push([INCREMENT]);


We can do this later when we revisit this API to move it out of experimental, but shouldn't we have some way of reaching into the reducer inside the zkapp to pull the pendingActions out for testing? It's brittle to need to remember to push the actions.

I really like how this library handles testing reducers https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/teststore

yeah I agree. I think this would be achieved if reducer.getActions -- which will fetch actions in the real network interaction -- gets them from memory in the LocalBlockchain case

bkase · 2022-07-14T23:32:37Z

src/lib/circuit_value.test.ts

@@ -0,0 +1,15 @@
+import { Bool, Circuit, isReady, shutdown, Int64 } from '../../dist/server';
+
+describe('circuit', () => {


good point yeah 0 is fine, but can you add a test for the zero case succeeding too?

bkase · 2022-07-14T23:34:04Z

src/lib/zkapp.ts

+    stateType: AsFieldElements<State>,
+    reduce: (state: State, action: Action) => State,
+    initial: { state: State; actionsHash: Field },
+    advancedOptions?: { maxTransactionsWithActions?: number }


this is nice

probably just options? is fine

mitschabaude added 19 commits July 5, 2022 16:22

emit state update

06ca649

fix circuitValue

b6b4e22

fix sequenceState precondition

56ed414

Merge branch 'feature/circuit-value-tweaks' into feature/sequence-events

3a35ed6

add Circuit.pickOne

61cbf2b

implement sequence state hashing

829c0d4

implement stateUpdate.applyUpdates

761f34b

export Circuit.pickOne separately as well

a4a1691

SmartContract.runOutsideCircuit, runs just once

1dc8eb2

example for rolling up state updates

b004963

handle more rolled-up txs by default

3580c8a

run methods ahead of time to count sequence events

ddacc84

add comment

a46489a

tweak types & make example clearer

7c17b28

use proofs by default

bd8d31b

Merge branch 'main' into feature/sequence-events

39e4ec3

revert changes to simple_zkapp

515e672

fix {state,precondition}.get() in analyze mode

6561480

add missing preconditions to example & simplify

fc4dcf7

mitschabaude mentioned this pull request Jul 7, 2022

Sequence Events RFC #265

Closed

remove junk

528fa94

mitschabaude commented Jul 7, 2022

View reviewed changes

bkase reviewed Jul 14, 2022

View reviewed changes

mitschabaude added 5 commits July 14, 2022 10:16

rename to Circuit.switch, throw on invalid mask

8e725af

use reducer terminology

9075114

make stuff not extend AsFieldElements<unknown>

f9d34cc

make reducer API flexible w.r.t. state & reduce

d0ecb1d

mark reducer API as experimental

3260855

This was referenced Jul 14, 2022

Properly constrain zkApp party #278

Merged

Expose constraint_system for running circuits in analyze mode #279

Merged

bkase approved these changes Jul 14, 2022

View reviewed changes

mitschabaude added 2 commits July 15, 2022 08:48

address pr feedback

60882d7

update bindings

925a57f

mitschabaude merged commit 8e5adf1 into main Jul 15, 2022

mitschabaude deleted the feature/sequence-events branch July 15, 2022 06:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sequencing events #274

Sequencing events #274

mitschabaude commented Jul 6, 2022 •

edited

mitschabaude Jul 7, 2022

mitschabaude Jul 7, 2022

mitschabaude Jul 7, 2022

mitschabaude Jul 7, 2022

bkase left a comment

bkase Jul 13, 2022

mitschabaude Jul 14, 2022 •

edited

bkase Jul 14, 2022

bkase Jul 14, 2022

bkase Jul 14, 2022

mitschabaude Jul 14, 2022

bkase Jul 14, 2022

bkase Jul 14, 2022

mitschabaude Jul 15, 2022

bkase Jul 14, 2022

bkase Jul 14, 2022

bkase Jul 14, 2022

		@@ -0,0 +1,15 @@
		import { Bool, Circuit, isReady, shutdown, Int64 } from '../../dist/server';

		describe('circuit', () => {

Sequencing events #274

Sequencing events #274

Conversation

mitschabaude commented Jul 6, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bkase left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mitschabaude Jul 14, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mitschabaude commented Jul 6, 2022 •

edited

mitschabaude Jul 14, 2022 •

edited