latest API of snarkyjs #36

mimoo · 2021-12-01T18:59:23Z

No description provided.

…ples

…js into feature/workshop-examples

…feature/workshop-examples

src/lib/merkle_stack.ts

src/lib/merkle_proof.ts

src/lib/data_store.ts

src/lib/circuit_value.ts

src/lib/optional.ts

src/lib/proof_system.ts

src/lib/party.ts

mitschabaude · 2022-01-11T15:24:51Z

src/lib/party.ts

+export class Perm {
+  constant: Bool;
+  signatureNecessary: Bool;
+  signatureSufficient: Bool;


It would be less confusing to me if "signatureSufficient" would instead be called "proofNecessary", and the Bool negated (if that's accurate)

What exactly does constant mean? I thought whether no one has the permission, but below it's also used for the case where everyone has the permission..

src/lib/party.ts

.github/workflows/doc.yml

package.json

src/build/build.mjs

src/index.ts

package.json

src/build/buildWeb.mjs

src/build/run.mjs

jasongitmail · 2022-01-11T20:54:56Z

src/examples/simple_snapp.ts

+} from '@o1labs/snarkyjs';
+
+class SimpleSnapp extends SmartContract {
+  @state(Field) x = State<Field>();


Reminder: we need to PR the docs after this update is merged please, so the changes are reflected in the docs.

And change the examples (at least the ones in snapp CLI)

src/examples/simple_snapp.ts

src/lib/int.ts

jasongitmail · 2022-01-11T23:09:17Z

src/lib/int.ts

+    return new Int64(this.value.sub(y.value));
+  }
+
+  repr(): { magnitude: Field; isPos: Sgn } {


What does this method do?

bkase · 2022-01-11T22:12:41Z

src/examples/ex02_root.ts

@@ -15,9 +24,24 @@ class Main extends Circuit {
  }
 }

+console.log('generating keypair...');


are these console logs all junk?

To be honest - I run this example file often for testing, and I like them because the whole operation takes more than 10 seconds and this waiting time is less confusing/annoying if you see what is currently happening. We could remove the timings

src/examples/wip.ts

src/lib/data_store.ts

bkase · 2022-01-11T22:21:14Z

src/lib/int.ts

+      ];
+    }
+
+    y_ = y_.seal();


and seal here (or more broadly, anywhere). What does the seal function do? Can we document this better?

seal and rangeCheckHelper both have TODOs in snarky.d.ts to document cc @imeckler to provide color for what these methods do

I can see what rangeCheckHelper does from context -- is there a good reason this needs to be bridged instead of just reimplemented in typescript? is it doing something particularly special under-the-hood that we can't remake in user-space?

src/lib/party.ts

jasongitmail · 2022-01-11T23:13:57Z

General comment: Our builds are output to web & server directories. I prefer that naming convention over than chrome and node unless we're intended to maintain separate code for different runtimes, it'd make sense to stick with the generic names and list which runtimes we support in the README.

mitschabaude · 2022-01-12T09:13:59Z

General comment: Our builds are output to web & server directories. I prefer that naming convention over than chrome and node unless we're intended to maintain separate code for different runtimes, it'd make sense to stick with the generic names and list which runtimes we support in the README.

I agree, at least with chrome -> web, but I'd rather make it server -> node because the node code is specifically targeted at the node runtime, not so much at a server environment. (And the web code is targeted at browser runtimes more than at being run on a website). If we at one point were to add deno compatibility, there's a small likelihood that we could reuse the web code, because the deno runtime tries to be close to web standards - but we could definitely not use the node code (and then the "server" label would become wrong).

I'll change the bindings directories' names after I changed them in the mina repo to keep copying simple, but will wait for that until everything is merged together there because merging changed directories is a pain

mitschabaude · 2022-01-12T10:05:13Z

FYI, I now merged in the latest version of the @state API, I think @imeckler didn't have time to review it but I wanted to get a stable version out there and avoid having to change docs & examples again later. The only changes are in src/lib/snapp.ts.

src/lib/snapp.ts

Remove uses of JS classes in OCaml, part 2

bkase and others added 30 commits November 5, 2021 01:27

Everything to Update typechecks

25c0f1b

A few more types

eb51d9f

WIP on wip

b1cce47

tsconfig

ce2d2a1

optional

e3bdfeb

uint

dd12f93

proof system

fb942d3

data store

9c4aaea

merkle stack

c8f5c87

snapp stuff

7ed90ca

merkle stuff

ce5981b

mina api

be2058c

party stuff

2046e9d

new example

801db98

update chrome bindings

c79c8a3

updates

988ce8a

update bindings

35557b6

remove throws

c554a1c

rename start:exec to exec

05d61e0

Starts to doccomment SnarkyJS

95ce9c6

Merge remote-tracking branch 'origin/main' into feature/workshop-exam…

aca97ac

…ples

fix build errors, add snarky-class-spec.json

cf1f909

some updates

4b5d3ae

API cleanup

fabe8ac

Merge branch 'feature/workshop-examples' of github.com:o1-labs/snarky…

78523b7

…js into feature/workshop-examples

to constant

7b0e4c1

Merge remote-tracking branch 'origin/feature/workshop-examples' into …

542363e

…feature/workshop-examples

update bindings

1a7a778

fix script

cc9b9fa

fixes

d35f76f

update class sped

804734d

mitschabaude reviewed Jan 11, 2022

View reviewed changes

src/lib/merkle_stack.ts Outdated Show resolved Hide resolved

mitschabaude added 3 commits January 11, 2022 13:31

fix deploy example & error msg

027f396

remove unused type

ffe57cb

remove unused imports and comment

3a20c66

mitschabaude reviewed Jan 11, 2022

View reviewed changes

MartinMinkov reviewed Jan 11, 2022

View reviewed changes

.github/workflows/doc.yml Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

src/build/build.mjs Show resolved Hide resolved

src/index.ts Outdated Show resolved Hide resolved

review suggestions

b813f07

jasongitmail reviewed Jan 11, 2022

View reviewed changes

bkase reviewed Jan 11, 2022

View reviewed changes

Merge branch 'feature/simpler-state' into feature/workshop-examples

a945cb6

mitschabaude added 5 commits January 12, 2022 11:12

remove comment

19fd5a8

address some review suggestions

ad21da3

remove unnecessary / unimplemented exports

c3f3f4c

move WIP /lib code out of snarkyjs, into example

2ee9622

@o1labs/snarkyjs -> snarkyjs

c66466e

mitschabaude reviewed Jan 12, 2022

View reviewed changes

src/lib/snapp.ts Show resolved Hide resolved

mitschabaude mentioned this pull request Jan 18, 2022

Code style clean-up #67

Closed

mitschabaude added 4 commits January 19, 2022 16:00

remove isTrue / isFalse from Boolean

fcdd282

make some valid code look less unfinished

669664e

change file name to mark it as unused

4312933

change file name to mark it as unused

2ea75aa

mitschabaude approved these changes Jan 19, 2022

View reviewed changes

0.2.0

92592ba

mitschabaude merged commit 3789dcd into main Jan 19, 2022

mitschabaude deleted the feature/workshop-examples branch May 9, 2022 14:30

mitschabaude added a commit that referenced this pull request Sep 5, 2023

Merge pull request #36 from o1-labs/refactor/cleanup-2

0989c32

Remove uses of JS classes in OCaml, part 2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

latest API of snarkyjs #36

latest API of snarkyjs #36

mimoo commented Dec 1, 2021

mitschabaude Jan 11, 2022

mitschabaude Jan 11, 2022

jasongitmail Jan 11, 2022

mitschabaude Jan 12, 2022

jasongitmail Jan 11, 2022 •

edited

Loading

mitschabaude Jan 12, 2022

bkase Jan 11, 2022

mitschabaude Jan 12, 2022

bkase Jan 11, 2022

bkase Jan 11, 2022

bkase Jan 11, 2022

jasongitmail commented Jan 11, 2022 •

edited

Loading

mitschabaude commented Jan 12, 2022

mitschabaude commented Jan 12, 2022 •

edited

Loading

latest API of snarkyjs #36

latest API of snarkyjs #36

Conversation

mimoo commented Dec 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasongitmail Jan 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasongitmail commented Jan 11, 2022 • edited Loading

mitschabaude commented Jan 12, 2022

mitschabaude commented Jan 12, 2022 • edited Loading

jasongitmail Jan 11, 2022 •

edited

Loading

jasongitmail commented Jan 11, 2022 •

edited

Loading

mitschabaude commented Jan 12, 2022 •

edited

Loading