Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SnarkyJS run inside a web worker #377

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Make SnarkyJS run inside a web worker #377

merged 1 commit into from
Sep 7, 2022
+2 −2

Conversation

mitschabaude
Copy link
Member

@mitschabaude mitschabaude commented Sep 1, 2022 •
edited

This PR exists to work on #378

@maht0rz
Copy link
Contributor

maht0rz commented Sep 2, 2022

I have tested this fix manually in Chrome v104 with new Worker(...), it no longer crashes when calling await isReady inside a web worker. I have not been able to test any further, since i am running into an infinite loop while compiling in a browser (while it works in the CLI).

@mitschabaude mitschabaude mentioned this pull request Sep 7, 2022
Merged
@mitschabaude mitschabaude merged commit 8123240 into main Sep 7, 2022
@mitschabaude mitschabaude deleted the feature/snarkyjs-in-workers branch September 7, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkase bkase bkase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make snarkyjs run inside a web worker
3 participants
@mitschabaude @maht0rz @bkase