-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uneccessary static methods #519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/lib/int.test.ts
Outdated
expect(x.value).toEqual(new UInt32(Field(1)).value); | ||
it('should be the same as Field.one', () => { | ||
const x = UInt32.from(1); | ||
expect(x.value).toEqual(new UInt32(Field.one).value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this change and similar ones going against our deprecation of Field.one
? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ye thats right, I accidentally kept the old changes from the merge conflict
Removes
.fromString()
,.fromNumber()
and.fromBigInt()
onField
,UInt64
,UInt32
andInt64
closes #486