-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Struct issues #567
Merged
Merged
Fix Struct issues #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
changed the title
Fix nested Struct type inference
Fix Struct issues (type inference, APIs not accepting Structs with methods, fromJSON)
Nov 28, 2022
mitschabaude
changed the title
Fix Struct issues (type inference, APIs not accepting Structs with methods, fromJSON)
Fix Struct issues (type inference, APIs not accepting Structs, fromJSON)
Nov 28, 2022
mitschabaude
changed the title
Fix Struct issues (type inference, APIs not accepting Structs, fromJSON)
Fix Struct issues
Nov 28, 2022
Trivo25
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just left a small comment
@mitschabaude Hey, can you export these two types for external use? This allows developers to use these types to support various custom Structs as parameters of generic methods. type FlexibleProvable<T> = Provable<T> | Struct<T>;
type FlexibleProvablePure<T> = ProvablePure<T> | StructPure<T>; |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes type inference in the following code example:
The type inference is changed in a way that it tries to not affect cases where inferring a class type already worked (e.g., CircuitValues like
UInt32
)EDIT: this PR now is about fixing more issues with Struct that came up
Struct.fromJSON