Fix/apple silicon performance #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mitschabaude
approved these changes
Jan 9, 2023
| 'apple m1 max': 3, | ||
| 'apple m1 ultra': 7, | ||
| 'apple m2': 2, | ||
| 'SSR': ((numCpus / 6) >> 0) + 1, |
There was a problem hiding this comment.
could you elaborate on that case? I'd assume that if server-side rendering prevents getGPUTier from running on the client, then snarkyjs won't run on the client in its entirety, so this case doesn't really matter? Or am I wrong?
Trivo25
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First merge: MinaProtocol/mina#12479
Explain your changes:
Explain how you tested your changes:
Caveats:
If the page is rendered serverside, we can't detect the platform. So we default the number of workers to a conservative guess. There is probably a way to enforce that the detect-gpu code runs client-side (in most cases), but I don't have a ton of experience with front-end frameworks and didn't think this was a high priority.
Mobile devices aren't accounted for yet (many of them (even if they don't run Apple silicon) will suffer from the same problem (but it's easy to add support any time)).
Values for the number of workers are hard-coded and based on limited testing.
Closes Run using only one thread on M1 processors #491