add nullifier to snarkyjs and mina-signer #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/nullifier
Trivo25
changed the base branch from
feature/hashToCurve
to
feature/hashToCurve-bindings
… into feature/nullifier
Trivo25
commented
May 8, 2023
mitschabaude
reviewed
May 9, 2023
There was a problem hiding this comment.
Awesome work! Do you mind making some changes to the doc comments in nullifier.ts?
Could you include a short summary of the paper in the class declaration comment? I think even something like this would be incredibly helpful (which is taken directly from the abstract):
Nullifiers are used as a public commitment to a specific anonymous account, to forbid actions like double spending, or allow a consistent identity between anonymous actions.
Could you also include an @example section in each method? I think it'd be really helpful to see these in your intellisense as you're exploring the API to give some hints to a developer. This will also really help our API reference.
mrmr1993
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements the
Nullifieras a new primitive in both mina-signer and SnarkyJS (in-snark variant) and demonstrates its usage insrc/examples/nullifier.tssee https://eprint.iacr.org/2022/1255.pdf
bindings o1-labs/o1js-bindings#10
closes #816
RFC: #756