-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move low-level operations to JS #967
Merged
Merged
Changes from 19 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
933455f
move Group.add to JS
Trivo25 f89ce6d
clean up imports
Trivo25 e5786a2
fix seal
Trivo25 3e3998b
fix if statement
Trivo25 633e621
changelog and update bindings
Trivo25 822baa4
changelog
Trivo25 574b267
rewrite assertOnCurve
Trivo25 354e0a5
fix zero handling both in var and const implementations
Trivo25 3f7276a
uncomment code
Trivo25 61ea3c1
comment
Trivo25 ae68c1c
handle negation
Trivo25 072557d
constant scale zero
Trivo25 d145b0b
add tests
Trivo25 f412241
make zero 0
Trivo25 fa47f32
Merge branch 'main' into refactor/group-add
Trivo25 e358157
comments
Trivo25 bce7d29
comments
Trivo25 925f16e
bindings
Trivo25 54c32a1
bindings
Trivo25 edc88a1
add tests
Trivo25 8c3b50f
fix proving and constraints
Trivo25 11913a8
Merge branch 'main' into refactor/group-add
Trivo25 d937a1e
build bindings and add tests
Trivo25 6e80437
dump new vks
Trivo25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule bindings
updated
from dcf4ee to c7cc23
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use the quickcheck generator Gregor made earlier to check some of the algebraic properties for edge cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about that as well, however, I think there is no easy way to sample valid Group elements other than brute forcing (or is there?) that's why the existing tests mostly work with the generator and
(-1, 2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used to sample public keys (= group elements) by picking a random private key (= scalar) and scaling the group generator with it.
That's not super efficient but good enough.
However, now we have hashToCurve which should be faster, especially if you skip the hash and only do random field element + mapToCurve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, I didn't consider that at all 😵💫 I'll add some more tests, just to be sure!