Blocking SnarkyJS CI tests #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
force-pushed
the
feature/revive-snarkyjs-ci-develop
branch
from
521ce79
to
7062619
Compare
mitschabaude
changed the title
bkase
approved these changes
Jun 22, 2023
| @@ -0,0 +1,156 @@ | |||
| import { | |||
There was a problem hiding this comment.
never, but I hope to reconcile some Mina tests which are currently in snarkyjs/tests/integration and are written in raw JS w/o types, with this directory
mrmr1993
approved these changes
Jun 22, 2023
| await testRecursion(MaxProofsVerifiedOne, 1); | ||
|
|
||
| async function testRecursion( | ||
| Program: typeof MaxProofsVerifiedOne, |
There was a problem hiding this comment.
Nit: should this be explicit? I think we want to have to change things if the backend changes, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion of MinaProtocol/mina#13430
./run --bundlescript to build & run TS scripts on the fly./runhandle our entire code base, and don't mix the worker code into the bundle, we stop bundling atwrapper.js(which has the compiled wasm/jsoo artifacts as dependencies)src/bindings/compiled/_node_bindings). Themakescript now puts compiled artifacts into that folder instead of into/dist./distafter invoking the TS compilersrc) is no longer valid. We instead add an empty declaration filesnarky_js_bindings.bc.d.ctswhich also stops TS from looking at that fileAll in all, the build setup is a bit more logical and less hacky now - in particular, files are located where they are imported from and it's actually possible to bundle the entire TS code base without copying around files before doing that