Functionality inside Trace to obtain relation columns used in lookups
#2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports a new functionality inside the
Tracestruct to extract the columns used in lookups, which shall be used in the delayed lookup argument.The rough idea is to recurse over the values of each lookup expression for each instruction/step variant, so that upon initialization of the decomposed traces, the lookup-related columns are identified. This means "collecting" them has no impact on the witness generation code.
Note that columns are extracted in generic shape. If we wanted to have them in alias shape, then we would need to create all the expressions in alias shape and then before calling the prover, convert them into generic shape.