[EASY] IVC: attempt to define the real number of columns #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/fixing-old-wrong-code-n-col
branch
2 times, most recently
from
d083fdd
to
feefa5b
Compare
And clean old not functional/drafty code
dannywillems
force-pushed
the
dw/fixing-old-wrong-code-n-col
branch
from
feefa5b
to
6382aef
Compare
dannywillems
changed the title
dannywillems
changed the title
dannywillems
force-pushed
the
dw/fixing-old-wrong-code-n-col
branch
from
16a53e7
to
8800bbb
Compare
The variable N_COL only defines the number of columns used by the current layout, without quadri.
dannywillems
force-pushed
the
dw/fixing-old-wrong-code-n-col
branch
from
8800bbb
to
f0d4e07
Compare
volhovm
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And clean old not functional/drafty code
In #2368 and in tests, we use this value to build real world examples.