[EASY] IVC/Columns: simply move circuit layout to top-level + doc block height #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
changed the title
dannywillems
commented
Jun 20, 2024
| @@ -1,3 +1,214 @@ | |||
| //! IVC circuit layout - Top level documentation outdated | |||
There was a problem hiding this comment.
Simply moving to the top + add one ```text`
dannywillems
commented
Jun 20, 2024
| //! | ||
| //! Assume that IVC circuit takess CELL cells, e.g. CELL = 10000*N. | ||
| //! Then we can calculate N_IVC as dependency of N_APP in this way: | ||
| //! ```text |
There was a problem hiding this comment.
Text formatting has been added here.
dannywillems
force-pushed
the
dw/add-doc-block-height-columns
branch
2 times, most recently
from
3276302
to
937170b
Compare
dannywillems
changed the base branch from
master
to
dw/fixing-old-wrong-code-n-col
dannywillems
force-pushed
the
dw/add-doc-block-height-columns
branch
2 times, most recently
from
ae11355
to
17f4d5d
Compare
dannywillems
commented
Jun 20, 2024
This is useful to generate the doc, and verifying the code matches the specification while reviewing/implementing.
dannywillems
force-pushed
the
dw/add-doc-block-height-columns
branch
from
17f4d5d
to
7dccc57
Compare
volhovm
approved these changes
Jun 24, 2024
dannywillems
force-pushed
the
dw/fixing-old-wrong-code-n-col
branch
from
8800bbb
to
f0d4e07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to generate the doc, and verifying the code matches the specification while reviewing/implementing.
I noticed some inconsistencies between the code and the specification.
Also, changing 6 to 12 for the number of hashes required per commitment. See the comment in the code. I added #2368 to verify we can still handle the MIPS interpreter.