New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reduce_to_prover #148
Merged
Merged
Add reduce_to_prover #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without #145:
|
This was referenced Mar 20, 2019
Merged
imeckler
approved these changes
Mar 26, 2019
src/snark0.ml
Outdated
let s', (_ : unit option) = run_as_prover (Some x) s in | ||
f s' ) | ||
, a ) | ||
| Pure x -> ((fun s -> s), x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this allocates but you could also do Fn.id
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
reduce_to_prover
, whichChecked.t
Checked.t
except forAs_prover
blocksAs_prover
blocks as maps over theRun_state.t
Checked.Direct
Effectively, this caches everything that can be known ahead of time in closures around the
As_prover
blocks, so that creating a proof fromreduce_to_prover Data_spec.[...] main
only runs theAs_prover
blocks frommain
.Combined with #145, this gives:
vs. without calling
reduce_to_prover
:That is,
reduce_to_prover
runs in 45% of the time for 10 runs, or 50% for 4 runs.(I overwrote my benchmarks file by mistake, so I haven't included a comparison with current master..)