Changes after first round of JOSS review #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
getting rid of one of my favourite words with more suitable ones!
as suggested in o2r-project#156
This was referenced Aug 15, 2019
partial of o2r-project#156
Add/dockerfile
36 tasks
vsoch
reviewed
Aug 16, 2019
| @@ -0,0 +1,19 @@ | |||
| FROM rocker/r-base:latest | |||
|
|
|||
There was a problem hiding this comment.
Just want to double check here - using a latest tag is usually a big dangerous because it's a moving target. Would it make sense to build from a specific version instead, to be updated when you are absolutely ready?
nuest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done