Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Preview" link in the creation view #151

Open
nuest opened this issue Apr 3, 2020 · 6 comments
Open

Add "Preview" link in the creation view #151

nuest opened this issue Apr 3, 2020 · 6 comments
Assignees
Projects

Comments

@nuest
Copy link
Member

nuest commented Apr 3, 2020

When looking at the current candidate draft, e.g. https://o2r.uni-muenster.de/#/createERC/lnXZx, then I must manually change the URL to get a preview, i.e. https://o2r.uni-muenster.de/#/erc/lnXZx

This way it is hard for authors to test-run their ERC without publishing it first. Should open a new tab.

Related to #149

@MarkusKonk MarkusKonk added this to To do in UI via automation Apr 9, 2020
@njakuschona njakuschona moved this from Backlog to Nice to have in UI Sep 18, 2020
@nuest nuest moved this from Next next to Next in UI Nov 13, 2020
@nuest nuest moved this from Next to Sprint in UI Nov 27, 2020
@Fmazin
Copy link
Contributor

Fmazin commented Nov 27, 2020

I modified the Go To ERC Button to display Preview while it is not published. This takes you to desired url in a new tab. View changed code in my fork.

However there are two problems:

  1. If you run an analysis in the preview tab and publish the ERC afterwards that analysis will be listed as run
  2. If change something in the createERC tab like metadata or a binding it will not be displayed in the Preview tab

Should i add the Preview Button anyway?

@Fmazin Fmazin moved this from Sprint to In progress in UI Nov 27, 2020
@nuest
Copy link
Member Author

nuest commented Nov 27, 2020

  1. Yes. Let's keep it that way - I think the most sensible way to handle that would be to allow owners to delete job runs > Add option to delete jobs api#95
  2. Not a problem. Maybe you can add a little frame or overlay that says "PREVIEW (will not be updated)" to make it clear to the user? I think users should not expect that the preview to be automatically updated across tabs.

@nuest
Copy link
Member Author

nuest commented Nov 27, 2020

Also, screenshots please :-)

@Fmazin
Copy link
Contributor

Fmazin commented Nov 30, 2020

Ok here are some screenshots of the new buttons

The preview button
Bildschirmfoto von 2020-11-30 14-30-28
And after the Publication
Bildschirmfoto von 2020-11-30 14-31-12

I will work on the iframe next.

@Fmazin
Copy link
Contributor

Fmazin commented Nov 30, 2020

I have added a preview notice in the window.
It is triggered when the ERC Overview Site is opened in a new tab.
Not a good solution now it is bound to if the the compedium in question is a candidate. This should only happen through a click on the preview button.
Bildschirmfoto von 2020-11-30 16-41-18

@nuest
Copy link
Member Author

nuest commented Dec 1, 2020

Looks nice. Can you increase the padding around the text please, and either have a margin both left and right, or no margin (though maybe that's just cut of in the screenshot).

Please open a PR so me and @NJaku01 can take a look at the code.

@Fmazin Fmazin moved this from In progress to Done - ask for review in UI Dec 4, 2020
@Fmazin Fmazin moved this from Done - ask for review to In progress in UI Dec 4, 2020
@Fmazin Fmazin moved this from In progress to Done - ask for review in UI Dec 4, 2020
njakuschona added a commit that referenced this issue Mar 11, 2021
Adding new pages titles #181, preview for candidate ERC #151 and disable synchronized scrolling #183
@Fmazin Fmazin moved this from Done - ask for review to Done in UI Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
UI
  
Done
Development

No branches or pull requests

2 participants