-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong license detected: GPL-3.0-only
#769
Comments
Seems related to jpeddicord/askalono#45 In this case we may want to display the aliases using |
Hm, that doesn't feel right. "Aliases" seem like a property of a specific license rather than being a property of the repository. If we want to display the repository's properties, then we should only see the specific license used in the repository. Otherwise, we still have to open up the repo and manually search for this information. |
It will complicate the code, but we could possibly try to get a Other than that, looking at
(note the "or any later version") This implies to me that The above ideas would probably be complex enough that they should be their own libraries IMO. |
With #851, this is close to being resolved. Perhaps just prioritizing the manifest's license over the license detected by askalono would be all that's needed. I think it's reasonable to prioritize values that the user has explicitly defined over detected values. As a very loose parallel, github/linguist prioritizes an explicit definition ( |
Makes sense, I pushed your suggestion @spenserblack e2af4ec |
Since @NatoBoram's example was with |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Confirmed fixed in onefetch 2.16.0 I guess that people using other frameworks can raise their own issue so it's easier to keep track of progress |
Duplicates
Current behavior 馃槸
Expected behavior 馃
Steps to reproduce 馃暪
npm init
license
toGPL-3.0-or-later
onefetch
The text was updated successfully, but these errors were encountered: