Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest crate #851

Merged
merged 33 commits into from
Nov 12, 2022
Merged

Add manifest crate #851

merged 33 commits into from
Nov 12, 2022

Conversation

o2sh
Copy link
Owner

@o2sh o2sh commented Nov 5, 2022

As a follow up to #845, this PR adds a new library to onefetch manifest that detects and parses package manifests, only Cargo.toml and package.json are supported for now.

As a result:

  • New info line -> Description
  • Fallback to manifest entries for:version number, repo's name and license -> if not found with gitoxide or askalono, we display the data extracted from the manifest (if present)
  • Remove DependencyDetector now part of manifest lib.

Left to do:

  • Add tests
  • Handle long description

@o2sh o2sh changed the title Add manifest crate to read repo_name, dependencies and description Add manifest crate to read repo_name, dependencies and description Nov 5, 2022
Copy link
Collaborator

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have been auto-selected for review by GitHub, but thought I'd leave some comments about parts that I think can be more idiomatic, which usually means 'objectively preferable', but maybe not always 😅. That said, I hope it's useful, otherwise, please ignore.

manifest/src/lib.rs Outdated Show resolved Hide resolved
manifest/src/lib.rs Outdated Show resolved Hide resolved
manifest/src/lib.rs Outdated Show resolved Hide resolved
src/info/repo/dependencies.rs Outdated Show resolved Hide resolved
src/info/repo/dependencies.rs Outdated Show resolved Hide resolved
src/info/repo/project.rs Outdated Show resolved Hide resolved
@o2sh o2sh changed the title Add manifest crate to read repo_name, dependencies, version and description Add manifest crate Nov 11, 2022
Co-authored-by: Spenser Black <spenserblack01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants